Re: [PATCH] ARM: dove: fix returnvar.cocci warnings

[Philip Li <philip.li@intel.com>]

On Fri, May 06, 2022 at 09:24:26AM +0200, Ard Biesheuvel wrote:
> On Fri, 6 May 2022 at 03:12, Philip Li <philip.li@intel.com> wrote:
> >
> > On Thu, May 05, 2022 at 09:31:37AM -0700, Dave Hansen wrote:
> > > On 5/3/22 00:21, Arnd Bergmann wrote:
> > > > On Tue, May 3, 2022 at 4:45 AM kernel test robot <lkp@intel.com> wrote:
> > > >> From: kernel test robot <lkp@intel.com>
> > > >>
> > > >> arch/arm/mach-omap2/dma.c:82:10-16: Unneeded variable: "errata". Return "0" on line 161
> > > >>
> > > >>  Remove unneeded variable used to store return value.
> > > >>
> > > >> Generated by: scripts/coccinelle/misc/returnvar.cocci
> > > >>
> > > >> Reported-by: kernel test robot <lkp@intel.com>
> > > >> Signed-off-by: kernel test robot <lkp@intel.com>
> > > > I checked the patch, and unfortunately it is wrong, the current code
> > > > needs to stay.
> > > > The problem is the SET_DMA_ERRATA() macro that accesses the
> > > > local 'errata' variable.
> > >
> > > 0day folks, do we have humans looking over these before they're going
> > > out to the list?  If not, can we add some?  If so, can the humans get a
> > > little more discerning? ;)
> >
> > Sorry all for the bad patch. So far, we pick up several cocci warnings that
> > we have confidence based on early result analysis and feedback, for these
> > warnings, 0day sends out patch automatically.
> >
> 
> Could you please add a special header or something to such emails so I
> can filter them out? I am strongly opposed to such automatic spambot
> patch generation, as it wastes valuable reviewer bandwidth to save the
> bot operator some time, but it think it should be the other way
> around.

Sorry for the trouble, we will stop sending the patch automatically and
only send out patch after human confirmed/reviewed.

> 
> We expect contributors to carefully prepare their patch submissions
> before sending them to the list, and automatically generated patches
> simply don't mesh with that. The fact that you use a bot does not mean
> you can ignore these rules.

Got it, we will improve this to follow the right way to send out patches.

Thanks