From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4139EC433EF for ; Wed, 11 May 2022 03:25:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A46C46B0073; Tue, 10 May 2022 23:25:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9F4D66B0075; Tue, 10 May 2022 23:25:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 896046B0078; Tue, 10 May 2022 23:25:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 76EF76B0073 for ; Tue, 10 May 2022 23:25:55 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id 3F1E981D35 for ; Wed, 11 May 2022 03:25:55 +0000 (UTC) X-FDA: 79452023070.06.48C39D3 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf04.hostedemail.com (Postfix) with ESMTP id 206DD400AD for ; Wed, 11 May 2022 03:25:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=VkXFC7bzqbGj7OElVHMSCDWMAQrJJqPUXLlLp7KIRUo=; b=O+KlwDisa+wcakNgXiR9ETfZ4s s5lsaKDwk0cDTkZc+jVyii9MlVKicZ+1zevNM86shfVuPnN4guK0j07qITQX5I0itkQ0XJL+23Rzo c6ZBuAxFOY80N/reEG0Lofjc6Wf9asG4XHgzBsUUSZaGxOeqkYwNK3yNEp/+X8AmaKtzG2NeQwu01 FFKGPfTOPilwQEwsJxoejbX2NM+O3Lr8gQ0Lga5orF6giU2SPv+qD5Q/+wwN+HI+/8Uy0Ncr0/nMb saXYppMMe4Nms18MY97rGYInrsWNuzJZfVdExG6WJnj7/Uyh1ANBxHOvKqVJRjdkAkizd2PzZB17T /f8YSTPA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nocyw-0054jE-94; Wed, 11 May 2022 03:25:46 +0000 Date: Wed, 11 May 2022 04:25:46 +0100 From: Matthew Wilcox To: Mike Kravetz Cc: akpm@linuxfoundation.org, linux-mm@kvack.org Subject: Re: [PATCH v2 18/26] mm/shmem: Convert shmem_add_to_page_cache to take a folio Message-ID: References: <20220504182857.4013401-1-willy@infradead.org> <20220504182857.4013401-19-willy@infradead.org> <02285994-89cf-18af-2047-ca576fff9565@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <02285994-89cf-18af-2047-ca576fff9565@oracle.com> X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 206DD400AD X-Stat-Signature: e95fhr6ougixcw85zr51b3qwra46dox3 Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=O+KlwDis; spf=none (imf04.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-HE-Tag: 1652239543-588468 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 10, 2022 at 08:06:44PM -0700, Mike Kravetz wrote: > On 5/4/22 11:28, Matthew Wilcox (Oracle) wrote: > > Shrinks shmem_add_to_page_cache() by 16 bytes. All the callers grow, > > but this is temporary as they will all be converted to folios soon. > > > > Signed-off-by: Matthew Wilcox (Oracle) > > --- > > mm/shmem.c | 57 +++++++++++++++++++++++++++++------------------------- > > 1 file changed, 31 insertions(+), 26 deletions(-) > > Hi Matthew, > > Was building next-20220510 without CONFIG_TRANSPARENT_HUGEPAGE set and > saw this BUILD_BUG. Looks like it might be related to this patch/series. This patch is the fixed version ;-) As I understand the bidding, I posted this patch series; Andrew integrated it (and many other patches) into mmotm, but one of the other patches he integrated caused a build error, so next-20220510 used an earlier version of mmotm. 0511 should see an mmotm with that problem fixed. Fingers crossed!