From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E076C433F5 for ; Mon, 16 May 2022 13:40:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 50BF36B0071; Mon, 16 May 2022 09:40:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4BC566B0072; Mon, 16 May 2022 09:40:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3830D6B0073; Mon, 16 May 2022 09:40:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 293B46B0071 for ; Mon, 16 May 2022 09:40:02 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id E502B20E82 for ; Mon, 16 May 2022 13:40:01 +0000 (UTC) X-FDA: 79471714602.12.96E44E2 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf02.hostedemail.com (Postfix) with ESMTP id 1B653800D4 for ; Mon, 16 May 2022 13:39:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ag+kYhBHOWVHyefgJy+1K09AOBdX5dHXPtZQwUVHJuA=; b=sVKb5rfhrwztbNXlQsxaBDThEY Jd72MNm9Nb2HCQ6eFtQlQwOL0coIvmAbA17ffxPAYu5wIMRcnFqK/K34tD71axZPLWVKczUkIZTv+ B7oZisAJTOwpCJWVaP756Ti8JeOX6+UrD1VJh4PvZMQpmlrmtaRB9U8AnDD9ZKHmolCFVVvo4LoVK rwxDgE3Z5tP2ERGFhOc4B1geKQgFCYbL6JlD24VmAmBRB5dT7qKcrSN/hDhrowvmVBwqS2tXmOEKp kvDZBgbczt5k8tKDo7qcr4exuG1oPIbIiUYcos3pPRdm4Fe2Qgm2KHHf8IcClRt+mXaWcmxRE5iIK NTv62z/g==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nqawz-0080Wh-RC; Mon, 16 May 2022 13:39:53 +0000 Date: Mon, 16 May 2022 06:39:53 -0700 From: Christoph Hellwig To: Dave Chinner Cc: Christoph Hellwig , "Darrick J. Wong" , Stefan Roesch , io-uring@vger.kernel.org, kernel-team@fb.com, linux-mm@kvack.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [RFC PATCH v1 11/18] xfs: add async buffered write support Message-ID: References: <30f2920c-5262-7cb0-05b5-6e84a76162a7@fb.com> <20220428215442.GW1098723@dread.disaster.area> <19d411e5-fe1f-a3f8-36e0-87284a1c02f3@fb.com> <20220506092915.GI1098723@dread.disaster.area> <31f09969-2277-6692-b204-f884dc65348f@fb.com> <20220509232425.GQ1098723@dread.disaster.area> <20220509234424.GX27195@magnolia> <20220510011205.GR1098723@dread.disaster.area> <20220516022430.GN1098723@dread.disaster.area> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220516022430.GN1098723@dread.disaster.area> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Stat-Signature: 19q397nd3k8kx787s316x84z4bih9taa X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 1B653800D4 X-Rspam-User: Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=sVKb5rfh; dmarc=none; spf=none (imf02.hostedemail.com: domain of BATV+e73cf5ef2c496becad12+6840+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+e73cf5ef2c496becad12+6840+infradead.org+hch@bombadil.srs.infradead.org X-HE-Tag: 1652708391-331606 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 16, 2022 at 12:24:30PM +1000, Dave Chinner wrote: > Ok, so we can just use XFS_I(file_inode(iocb->ki_filp)) then and we > don't need to pass the xfs_inode at all. We probably should convert > the rest of the io path to do this as well so we don't end up > forgetting this again... Yes.