From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AFAAC433EF for ; Thu, 19 May 2022 08:17:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C83106B0075; Thu, 19 May 2022 04:17:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C0B588D0007; Thu, 19 May 2022 04:17:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AD3E48D0006; Thu, 19 May 2022 04:17:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 9719A6B0075 for ; Thu, 19 May 2022 04:17:21 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 7228220B91 for ; Thu, 19 May 2022 08:17:21 +0000 (UTC) X-FDA: 79481787882.29.46037AA Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf23.hostedemail.com (Postfix) with ESMTP id 532F61400D2 for ; Thu, 19 May 2022 08:17:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=vsLx1/spK6mJV5vHHVr4BL4tfcrdDPT/6wGxnfZrwzQ=; b=Nueh0SVjlOcrYRUmlBQHIDStKp q/JvdZWEKOA5UXUsvj37TSFUhVV2uWFXDbOuq93KlW5L4pDnA/cTiawA+Lz+Tgd8dPqZg/7bHWYNr 6cyCAUf7pd93hmnOetbaWxTqMmT5OY7Yz2ylPys5QmGdjNW5lgZKP8vNcKsZxCgEyzV/Sw5k+zmWI lhLr1emyyulQrvY0od1NIv1cwaVflU4ZOM6d7hWVTD4iMOPcfbbKn1p0tbSdZ8ntpp54OVilGIA1E CeTKwCHoO2IWsMIQwknGmZfRiqycfNxeJ57amsIU/0LIrjtt9Xh/vLHKuNp0DSr6VdJLZ0moyd3xz eyiJA/ug==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nrbLR-005kBD-Ai; Thu, 19 May 2022 08:17:17 +0000 Date: Thu, 19 May 2022 01:17:17 -0700 From: Christoph Hellwig To: Stefan Roesch Cc: io-uring@vger.kernel.org, kernel-team@fb.com, linux-mm@kvack.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, david@fromorbit.com, jack@suse.cz Subject: Re: [RFC PATCH v3 01/18] block: Add check for async buffered writes to generic_write_checks Message-ID: References: <20220518233709.1937634-1-shr@fb.com> <20220518233709.1937634-2-shr@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220518233709.1937634-2-shr@fb.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 532F61400D2 X-Stat-Signature: p9jnetmc84x8y8zcick4sdqz44j4nrmk X-Rspam-User: Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=Nueh0SVj; spf=none (imf23.hostedemail.com: domain of BATV+015a865715d1323b7cbd+6843+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+015a865715d1323b7cbd+6843+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none X-HE-Tag: 1652948222-770070 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, May 18, 2022 at 04:36:52PM -0700, Stefan Roesch wrote: > @@ -1633,7 +1633,9 @@ int generic_write_checks_count(struct kiocb *iocb, loff_t *count) > if (iocb->ki_flags & IOCB_APPEND) > iocb->ki_pos = i_size_read(inode); > > - if ((iocb->ki_flags & IOCB_NOWAIT) && !(iocb->ki_flags & IOCB_DIRECT)) > + if ((iocb->ki_flags & IOCB_NOWAIT) && > + !((iocb->ki_flags & IOCB_DIRECT) || > + (file->f_mode & FMODE_BUF_WASYNC))) This is some really odd indentation. I'd expect something like: if ((iocb->ki_flags & IOCB_NOWAIT) && !((iocb->ki_flags & IOCB_DIRECT) || (file->f_mode & FMODE_BUF_WASYNC))) > diff --git a/include/linux/fs.h b/include/linux/fs.h > index bbde95387a23..3b479d02e210 100644 > --- a/include/linux/fs.h > +++ b/include/linux/fs.h > @@ -177,6 +177,9 @@ typedef int (dio_iodone_t)(struct kiocb *iocb, loff_t offset, > /* File supports async buffered reads */ > #define FMODE_BUF_RASYNC ((__force fmode_t)0x40000000) > > +/* File supports async nowait buffered writes */ > +#define FMODE_BUF_WASYNC ((__force fmode_t)0x80000000) This is the last available flag in fmode_t. At some point we should probably move the static capabilities to a member of file_operations.