From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79367C4332F for ; Thu, 19 May 2022 08:32:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E6D9B6B0072; Thu, 19 May 2022 04:32:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DF70D6B0073; Thu, 19 May 2022 04:32:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CE5DD6B0074; Thu, 19 May 2022 04:32:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id BAF886B0072 for ; Thu, 19 May 2022 04:32:13 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id 844C160935 for ; Thu, 19 May 2022 08:32:13 +0000 (UTC) X-FDA: 79481825346.01.E8333B5 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf06.hostedemail.com (Postfix) with ESMTP id 4135E180007 for ; Thu, 19 May 2022 08:32:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=z0VulKkXWTFJSRnaleVs6kNcyiBhFADcaZisxPBE7tM=; b=05s9ISOpfkpuTstanmUDq2bKnF 9pIoGjju+h4SX5a2iN7+aQonQ1woQTpJq0GxFgp4jsF3QArHF6Bj3YRoRJTaU2TYvf6qRq2meYvCa OwMd/dezqb6Gz1+EHcGXVTYpZcJDCOivmvyXqECE4TLt9He6snuQHz5YQbANRnqD0FA4vbmCDe8YK 46z5vlRBS/VJadmIc7tHAFflPRMmqVhxu38qS2ODFjCuCPKF3XsOl3nrV2seq3ayXqOyy2Lgzt3T1 VA38bdz9XaNf/bjBtQ53a/rnVKCbAZrrtqvp1RZGeDTjB4mjOXwgEZV1K3ZL2TjurGGG1PWrboYpl l2EF9Etg==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nrbZq-005s9y-VX; Thu, 19 May 2022 08:32:11 +0000 Date: Thu, 19 May 2022 01:32:10 -0700 From: Christoph Hellwig To: Stefan Roesch Cc: io-uring@vger.kernel.org, kernel-team@fb.com, linux-mm@kvack.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, david@fromorbit.com, jack@suse.cz Subject: Re: [RFC PATCH v3 16/18] iomap: Use balance_dirty_pages_ratelimited_flags in iomap_write_iter Message-ID: References: <20220518233709.1937634-1-shr@fb.com> <20220518233709.1937634-17-shr@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220518233709.1937634-17-shr@fb.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=05s9ISOp; spf=none (imf06.hostedemail.com: domain of BATV+015a865715d1323b7cbd+6843+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+015a865715d1323b7cbd+6843+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none X-Rspam-User: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 4135E180007 X-Stat-Signature: xpehyfiq5ukxkx546om86acbangnsh6d X-HE-Tag: 1652949130-776118 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > --- a/fs/iomap/buffered-io.c > +++ b/fs/iomap/buffered-io.c > @@ -784,6 +784,7 @@ static loff_t iomap_write_iter(struct iomap_iter *iter, struct iov_iter *i) > do { > struct folio *folio; > struct page *page; > + struct address_space *i_mapping = iter->inode->i_mapping; We tend to call these variables just mapping without the i_ prefix. > again: > + if (iter->flags & IOMAP_NOWAIT) { > + status = balance_dirty_pages_ratelimited_async(i_mapping); Which also nicely avoids the overly long line here. > + if (unlikely(status)) > + break; > + } else { > + balance_dirty_pages_ratelimited(i_mapping); > + } Then again directly calling the underlying helper here would be simpler to start with. unsigned int bdp_flags = (iter->flags & IOMAP_NOWAIT) ? BDP_ASYNC : 0; ... status = balance_dirty_pages_ratelimited_flags(mapping, bdp_flags); if (status) break;