From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EFA9C433F5 for ; Fri, 20 May 2022 07:43:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DD1576B0071; Fri, 20 May 2022 03:43:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D807B6B0072; Fri, 20 May 2022 03:43:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C6F956B0073; Fri, 20 May 2022 03:43:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id BA4B96B0071 for ; Fri, 20 May 2022 03:43:54 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 85E9134750 for ; Fri, 20 May 2022 07:43:54 +0000 (UTC) X-FDA: 79485332388.08.CAB826D Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) by imf28.hostedemail.com (Postfix) with ESMTP id 479E4C0010 for ; Fri, 20 May 2022 07:43:26 +0000 (UTC) Received: by mail-wr1-f45.google.com with SMTP id u3so10329205wrg.3 for ; Fri, 20 May 2022 00:43:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=R+xTlbVgKdrZc+/7f/CN0UJSdf1T+UIc9vh0/IvStRY=; b=B2pSvrOk1f9hjO5WWXg1eiWwB69RVrYV0DKQlPQxThciXJc+t+HWz/zfeYIjrZfoQH WNUH8o3HOOdrmpSVbgSSvjJlvYRcAygM1ikc0g8mEzFEdPuF/2004ZIbMhenqrcDWIgD HaJtigdCTlsQb2BOqAExzn/p2rq4uhbBbt/Rc2A4BJVX6+ZIo0dEQu2tYONtUdjY1YMu Pu2D91ZQnBeGMSUFRd8i7UgS8cDbaHbMneCOcIvrC3ZqSUBtTSboqtHV8UeYwcDFVJv9 ZgA6nBVMcmNYU9ebRMn0K7OYHuXex1QDIWuH9co7RxjtNi3xU/aE3PhAggV9dne/nEke /aww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=R+xTlbVgKdrZc+/7f/CN0UJSdf1T+UIc9vh0/IvStRY=; b=5sDYy5oMWmz/SNYm05G2EwHj7u/wDyKstXogFMhO4PSlOAcAHg7R09TWWUWVPIKndT GDpBy8wz60jTudHBwqJdDr3Tz2Gsxl0zItEMr3XfcKg8hZpd4aT6j5iE/OheE8lSEQt/ UdZpxAIKwJShIxlYxr9DwkeDoPhdvarNhVADh+3cg21zkslJWoaid2JkcCwv5g1k8hCc GpEDDYzDFGQUIvJc6Y7KdflrQdt9ITQxdww/3+Nu+4pliwDqdbuC3DBziF8z78Dsrc+w YdWyw18g8dIPLI5Li3s+ccNq1hZnzJa6jsHYPVCPruvx7X68jLkvUZswBng128JmPXkS PENw== X-Gm-Message-State: AOAM532lqA37ezjmgqinoBwd2ueIzsGfbkKKR2iJXIgHILwr0h1dBj0C yyDGNL2i/Qh9gdFYHdIY7ol1QA== X-Google-Smtp-Source: ABdhPJwWNqdoPb3zbJqVisqelRKAIGgw1BCnh/xktGD4AFDNSOPQhfb96FqAbI3w2yE9N0Fnsa2bAA== X-Received: by 2002:a05:6000:1e08:b0:20f:1b8c:799 with SMTP id bj8-20020a0560001e0800b0020f1b8c0799mr1136247wrb.716.1653032632688; Fri, 20 May 2022 00:43:52 -0700 (PDT) Received: from elver.google.com ([2a00:79e0:15:13:4060:dc55:7d4:3443]) by smtp.gmail.com with ESMTPSA id u6-20020adfc646000000b0020d0c48d135sm1763904wrg.15.2022.05.20.00.43.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 May 2022 00:43:52 -0700 (PDT) Date: Fri, 20 May 2022 09:43:46 +0200 From: Marco Elver To: Kefeng Wang Cc: Alexander Potapenko , Dmitry Vyukov , Andrew Morton , linux-mm@kvack.org, kasan-dev@googlegroups.com Subject: Re: [PATCH] mm: kfence: Use PAGE_ALIGNED helper Message-ID: References: <20220520021833.121405-1-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220520021833.121405-1-wangkefeng.wang@huawei.com> User-Agent: Mutt/2.1.4 (2021-12-11) X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 479E4C0010 X-Stat-Signature: ejcwotg65tsemskqdwp9pfzg5gqd9hjt Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=B2pSvrOk; spf=pass (imf28.hostedemail.com: domain of elver@google.com designates 209.85.221.45 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com X-HE-Tag: 1653032606-490853 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, May 20, 2022 at 10:18AM +0800, 'Kefeng Wang' via kasan-dev wrote: > Use PAGE_ALIGNED macro instead of IS_ALIGNED and passing PAGE_SIZE. > > Signed-off-by: Kefeng Wang Reviewed-by: Marco Elver > --- > mm/kfence/kfence_test.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/mm/kfence/kfence_test.c b/mm/kfence/kfence_test.c > index 96206a4ee9ab..a97bffe0cc3e 100644 > --- a/mm/kfence/kfence_test.c > +++ b/mm/kfence/kfence_test.c > @@ -296,10 +296,9 @@ static void *test_alloc(struct kunit *test, size_t size, gfp_t gfp, enum allocat > > if (policy == ALLOCATE_ANY) > return alloc; > - if (policy == ALLOCATE_LEFT && IS_ALIGNED((unsigned long)alloc, PAGE_SIZE)) > + if (policy == ALLOCATE_LEFT && PAGE_ALIGNED(alloc)) > return alloc; > - if (policy == ALLOCATE_RIGHT && > - !IS_ALIGNED((unsigned long)alloc, PAGE_SIZE)) > + if (policy == ALLOCATE_RIGHT && !PAGE_ALIGNED(alloc)) > return alloc; > } else if (policy == ALLOCATE_NONE) > return alloc; > -- > 2.35.3