From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8920AC433EF for ; Sun, 22 May 2022 21:24:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2317C8D0008; Sun, 22 May 2022 17:24:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1BAF18D0006; Sun, 22 May 2022 17:24:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 05BA48D0008; Sun, 22 May 2022 17:24:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id DABAB8D0006 for ; Sun, 22 May 2022 17:24:45 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 6A0A1333C0 for ; Sun, 22 May 2022 07:18:01 +0000 (UTC) X-FDA: 79492524762.17.D7BAC8D Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf26.hostedemail.com (Postfix) with ESMTP id A1D65140018 for ; Sun, 22 May 2022 07:17:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=FYdUNpYTCKI9E//psNaQ4qfwx/AZlbpXMSBjSm3xLAI=; b=jfnCuOiWUTnVFCUfR715RoX543 ALG2snduf5sX62r4QAYIZQJY3+3FI7aWgxv5kcf4/cA+XT6g4VHAFGePDnHXOlKJTBVVepKTaVPgr kzZKGBxQBr6Wx4FJKE/CEurvvAv+v0oKlGFLCMiHMn8sQxJwz+r1f0+hQicjHp/YskSQ7ElO5Iwl/ KPvhZ8OAfCKA1DT4B99UW7w9kHwJkPIQWcyIbpRyQJRqWjcUGGQ3lnLoqkzUtBjSeKmzSY22NL686 nP4tD70Y8sGdLrSEtUfVx/nmgBYb/swPIM8GgtHgb2xQIEJMAIEkogcaKs101kMCo+vvV+v/BtmZX 8Hhp4HHA==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nsfqW-000m5s-Rj; Sun, 22 May 2022 07:17:48 +0000 Date: Sun, 22 May 2022 00:17:48 -0700 From: Christoph Hellwig To: Stefan Roesch Cc: io-uring@vger.kernel.org, kernel-team@fb.com, linux-mm@kvack.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, david@fromorbit.com, jack@suse.cz, hch@infradead.org Subject: Re: [RFC PATCH v4 03/17] mm: Prepare balance_dirty_pages() for async buffered writes Message-ID: References: <20220520183646.2002023-1-shr@fb.com> <20220520183646.2002023-4-shr@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220520183646.2002023-4-shr@fb.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=jfnCuOiW; spf=none (imf26.hostedemail.com: domain of BATV+c9e7f944c22607b8b784+6846+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+c9e7f944c22607b8b784+6846+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none X-Rspam-User: X-Stat-Signature: hwoy65do3abaqyop77mukfjteh3n5ifh X-Rspamd-Queue-Id: A1D65140018 X-Rspamd-Server: rspam01 X-HE-Tag: 1653203875-46246 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, May 20, 2022 at 11:36:32AM -0700, Stefan Roesch wrote: > From: Jan Kara > > If balance_dirty_pages() gets called for async buffered write, we don't > want to wait. Instead we need to indicate to the caller that throttling > is needed so that it can stop writing and offload the rest of the write > to a context that can block. I don't tink this really makes sense without the next patch, so I'd suggest to merge the two.