From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 156D8C433FE for ; Sun, 22 May 2022 21:29:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3FDB28D0006; Sun, 22 May 2022 17:29:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3AE298D0009; Sun, 22 May 2022 17:29:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2C4638D0006; Sun, 22 May 2022 17:29:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 1601B8D0009 for ; Sun, 22 May 2022 17:29:49 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id E5C1133E4D for ; Sun, 22 May 2022 07:21:03 +0000 (UTC) X-FDA: 79492532406.28.92C15E7 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf02.hostedemail.com (Postfix) with ESMTP id 86C1A8002F for ; Sun, 22 May 2022 07:21:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=D+RDuGkgTlHyJXa032TQ7h0GInwRwZsNBFKCU/Zvtvc=; b=03wQAC1gq+rOa7vWkwjrzM+uvN aFGC+2ySanLPWTuEL5u7KrkNjp25bUz0AGByM7zjwQwQOFpTQ/f63h1OvLQk74LskO35RxU5SiZ60 m7asYXHbtWzIP6znoRU8LA424coozk2OesIYJxoyRoQdoi9FTkjhL6F9C3Bnrg/671gT/naKuzOSF DNYpEHW3ObBpaUcBNOFHmOYMNnK7JExjMU7Ch/pZYbu+gEqt6wum03/Qhxz23P0QgkzswTUYEr3+N lLVV+JeJwDk+ZStRV/qCNHXfQ7hGx2HsJUi0Jo6CjbRoWuBbDhADDL6y9JG5/l3phdr9itMrPQN8j vV3tUQjA==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nsftd-000mYo-4u; Sun, 22 May 2022 07:21:01 +0000 Date: Sun, 22 May 2022 00:21:01 -0700 From: Christoph Hellwig To: Stefan Roesch Cc: io-uring@vger.kernel.org, kernel-team@fb.com, linux-mm@kvack.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, david@fromorbit.com, jack@suse.cz, hch@infradead.org Subject: Re: [RFC PATCH v4 05/17] iomap: Add gfp parameter to iomap_page_create() Message-ID: References: <20220520183646.2002023-1-shr@fb.com> <20220520183646.2002023-6-shr@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220520183646.2002023-6-shr@fb.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=03wQAC1g; spf=none (imf02.hostedemail.com: domain of BATV+c9e7f944c22607b8b784+6846+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+c9e7f944c22607b8b784+6846+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none X-Rspam-User: X-Stat-Signature: wx8azgu8x5sk4xsi4xu3h6g1433wjznx X-Rspamd-Queue-Id: 86C1A8002F X-Rspamd-Server: rspam01 X-HE-Tag: 1653204061-225508 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, May 20, 2022 at 11:36:34AM -0700, Stefan Roesch wrote: > - iop = kzalloc(struct_size(iop, uptodate, BITS_TO_LONGS(nr_blocks)), > - GFP_NOFS | __GFP_NOFAIL); > + iop = kzalloc(struct_size(iop, uptodate, BITS_TO_LONGS(nr_blocks)), gfp); Please avoid the overly long line. Looking at this I also thnk my second suggestion of just passing the flags to iomap_page_create and let iomap_page_create itself pick the gfp_t might be the better option here.