From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65EEAC433EF for ; Sun, 22 May 2022 21:29:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 005A78D0008; Sun, 22 May 2022 17:29:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EF8048D0006; Sun, 22 May 2022 17:29:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E0E158D0008; Sun, 22 May 2022 17:29:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id D05F18D0006 for ; Sun, 22 May 2022 17:29:48 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id EF017982 for ; Sun, 22 May 2022 07:24:06 +0000 (UTC) X-FDA: 79492540092.05.05BBDE2 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf21.hostedemail.com (Postfix) with ESMTP id 927061C0002 for ; Sun, 22 May 2022 07:23:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=jpqo4ZefQHaMA5S5OSvPtjCRSete+aQ/dNFBECqTMkk=; b=mBiqo/L1d9jx1h/KO3v4izVQWv DoleK9XcwWp1+QBH17/8SZWzkg6Y5U1IO2sL9rJlhgtQpiJnv4uITRuB7u9WWjSav+HZgKEdYB+J6 7QRX+1kpnb2BDAxKMlC2zbRvxM3PdwPLLJ0eyy5zMZcfUNAGb3uKW+IkbiaLq2Qm1RJQlIKf9FIdb ZqCLiA9S9Fqu62fcbxkU+gBfNoAY2nbehNOKmJiMoIl82DMMcH1VkcjZOGjUHYZIEOv+uSq7S9Bmj jF4rC86x+RyM+FvaPcb9NGbzOvetOdRblsgaMyRcncrmdb65F4pr03TVY1FmwD2DPE/B9jYTH2BVH 50kvDqfA==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nsfwZ-000mrI-Ls; Sun, 22 May 2022 07:24:03 +0000 Date: Sun, 22 May 2022 00:24:03 -0700 From: Christoph Hellwig To: Stefan Roesch Cc: io-uring@vger.kernel.org, kernel-team@fb.com, linux-mm@kvack.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, david@fromorbit.com, jack@suse.cz, hch@infradead.org Subject: Re: [RFC PATCH v4 11/17] fs: Add async write file modification handling. Message-ID: References: <20220520183646.2002023-1-shr@fb.com> <20220520183646.2002023-12-shr@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220520183646.2002023-12-shr@fb.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 927061C0002 X-Rspam-User: Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b="mBiqo/L1"; spf=none (imf21.hostedemail.com: domain of BATV+c9e7f944c22607b8b784+6846+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+c9e7f944c22607b8b784+6846+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none X-Stat-Signature: k6yshp8cmyi9swgct8k4brd7wmu1hx3q X-HE-Tag: 1653204235-831212 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > +int file_modified_async(struct file *file, int flags) file_modified_flags? Or even bette kiocb_modified and pass the kiocb as that makes is very clear which flags we use by making that implicit. > +EXPORT_SYMBOL(file_modified_async); EXPORT_SYMBOL_GPL, please. > - return file_modified(file); > + return file_modified_async(file, iocb->ki_flags); And this should go into the XFS enablemnt patch. > extern int file_modified(struct file *file); > +extern int file_modified_async(struct file *file, int flags); No need for the extern here, or any function declarations for that matter.