From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 077FDC433EF for ; Sun, 22 May 2022 21:39:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A2F7B8D0009; Sun, 22 May 2022 17:39:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9B8DD8D0006; Sun, 22 May 2022 17:39:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 880DD8D0009; Sun, 22 May 2022 17:39:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 76D538D0006 for ; Sun, 22 May 2022 17:39:48 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id B8F31970 for ; Sun, 22 May 2022 07:32:29 +0000 (UTC) X-FDA: 79492561218.18.CE060F2 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf04.hostedemail.com (Postfix) with ESMTP id 9BC8940013 for ; Sun, 22 May 2022 07:32:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=OBykm/D/SYJ7gKlORyPx7N67S5gQLn7hn9NwpX1v5SU=; b=PMOm8v6Q+wNcm1jrngrSFqONja jVgBd8AYgnxsN3Ngg9iDtYbWz9qS4Av8r1Jgmvwspogs6v9wL6mkWtEoWdu7ZJVUg2jFrpeogETa9 ZOhnP+AhiKVLXGI40BDT/E+CD0IBgGd25cHNrLwBMR0mGCKsJGSg3ehJiQEDnRGCiGRJyvfjSmSn8 g1zE0SnFDsN4I6nGs8yhMbaA+6pmRFEfkZ87JwvPW3/xVI7a76eoS8LGhvUaEKyOiA8KA/8Vd0Qrx DHTz/zSd9wC87OgIGUsLz/QaxRN/5Zf/tykqXXwRRZWEM9I2KPw7hEbMa0O70YDeAQ7PVIPDk+Q1U ws1LL1FQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nsg4h-000nky-2K; Sun, 22 May 2022 07:32:27 +0000 Date: Sun, 22 May 2022 00:32:27 -0700 From: Christoph Hellwig To: Stefan Roesch Cc: io-uring@vger.kernel.org, kernel-team@fb.com, linux-mm@kvack.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, david@fromorbit.com, jack@suse.cz, hch@infradead.org Subject: Re: [RFC PATCH v4 09/17] fs: Split off remove_needs_file_privs() __remove_file_privs() Message-ID: References: <20220520183646.2002023-1-shr@fb.com> <20220520183646.2002023-10-shr@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220520183646.2002023-10-shr@fb.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Stat-Signature: jrbk7a4di4161ra49nxsecx8agxhwenk X-Rspam-User: Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=PMOm8v6Q; dmarc=none; spf=none (imf04.hostedemail.com: domain of BATV+c9e7f944c22607b8b784+6846+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+c9e7f944c22607b8b784+6846+infradead.org+hch@bombadil.srs.infradead.org X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 9BC8940013 X-HE-Tag: 1653204734-509236 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: So why don't we just define a __file_remove_privs that gets the iocb flags passed an an extra argument, and then make file_remove_privs pass 0 flags, and maybe also add a kiocb_remove_privs wrapper for callers that have the kiocb. Same for the timestamp update, btw. That seems less churn and less code overall.