From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E2F7C433EF for ; Sun, 22 May 2022 21:39:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2B5528D000A; Sun, 22 May 2022 17:39:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 217F88D0006; Sun, 22 May 2022 17:39:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0E06A8D000A; Sun, 22 May 2022 17:39:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id F05D98D0006 for ; Sun, 22 May 2022 17:39:58 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 74B1060B7F for ; Sun, 22 May 2022 07:33:49 +0000 (UTC) X-FDA: 79492564578.22.A6CB91C Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf15.hostedemail.com (Postfix) with ESMTP id 1C33AA0002 for ; Sun, 22 May 2022 07:33:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=4gdF6O3kUX9Och/QIOagwvCP4ijVcQquNR1zIJ/LzOY=; b=4Usxbn5+rwTA8NGZmpo+mf5yRu 8kWhWSCziTXwxyuMJZmmS6x5/iMjYMx9/tgohDjJP+0jloOY9iwB7IsKs8ydTzoVqVOauSMEIhN/X AGs7e8XrbTsjvLT/LuGRJZnqF/66+bnv/FNpUjlReSzrPd6qEc7nxbY0abWAXoXsN+EUvu7aL4mgl QQY4glFu9dIO2f2EoEk8fa2hfXx7BZiqZkWcKcteeQk8gMGKK/OdiJcKQRR3XvODTyKcQt66wK+XZ nv9ucmb4Kc1AxjP4usluux/bs+M89MPOL9OyzNIJYFIjT+OlI95Gzk7CLDP5zFMU8wuFExMA/qwBh cJCNkRCA==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nsg5y-000nwe-Kb; Sun, 22 May 2022 07:33:46 +0000 Date: Sun, 22 May 2022 00:33:46 -0700 From: Christoph Hellwig To: Stefan Roesch Cc: io-uring@vger.kernel.org, kernel-team@fb.com, linux-mm@kvack.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, david@fromorbit.com, jack@suse.cz, hch@infradead.org Subject: Re: [RFC PATCH v4 15/17] xfs: Add iomap async buffered write support Message-ID: References: <20220520183646.2002023-1-shr@fb.com> <20220520183646.2002023-16-shr@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220520183646.2002023-16-shr@fb.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: 1C33AA0002 X-Stat-Signature: nhekusmz4qwy9m3msphkxearfhrbhkim Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=4Usxbn5+; dmarc=none; spf=none (imf15.hostedemail.com: domain of BATV+c9e7f944c22607b8b784+6846+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+c9e7f944c22607b8b784+6846+infradead.org+hch@bombadil.srs.infradead.org X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1653204810-142336 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, May 20, 2022 at 11:36:44AM -0700, Stefan Roesch wrote: > This adds the async buffered write support to the iomap layer of XFS. If > a lock cannot be acquired or additional reads need to be performed, the > request will return -EAGAIN in case this is an async buffered write > request. > > This patch changes the helper function xfs_ilock_for_iomap such that the > lock mode needs to be passed in. So from a pure commit structure POV, I'd make the changes to xfs_ilock_for_iomap one separate and clearly document patch, and then merge all the rest of the XFS enablement into a single other patch.