From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 227B6C433F5 for ; Sun, 22 May 2022 21:09:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 93E9B8D0005; Sun, 22 May 2022 17:09:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8ED9B8D0001; Sun, 22 May 2022 17:09:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7B68E8D0005; Sun, 22 May 2022 17:09:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 659348D0001 for ; Sun, 22 May 2022 17:09:47 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 78B2D33B8D for ; Sun, 22 May 2022 07:35:01 +0000 (UTC) X-FDA: 79492567602.16.8B4E65C Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf19.hostedemail.com (Postfix) with ESMTP id 5DBFE1A0016 for ; Sun, 22 May 2022 07:34:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=WBuaIM5SKIXkLPP9GWovDc27LNx1rhfUlIGL8EkGrgs=; b=EwTBzO6RfBEUY2QPJdzOnVRXd2 +nQXck0mDSvWFS2pFxxni3O1VHw2qB9PX7111rCqBQGS2xHtBuNbsHRUzhLAhtomICYUikAecEc0H dRmnAYjm01u7kqAHYjfyU8sH0WZE/rysNjFbFvUnwzlijdOSoGaWMsZvQVwDE2jx4p8FWq6fkPc+v JCwDLtUzftgDrjbJWOdj73kOmWRKpX93IezC97pC7wOleWdut3zk1eo/btvhKupXJ0cOAiK/EpEzI CuW8xYYIMUsDYdAnQE7jk/3D6uIJuCxceN4f4LxDvCTNZHQZpS8GawlLeI9/vl3m9Mo8Ay77+85Hw dL3pBZww==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nsg78-000oB1-JL; Sun, 22 May 2022 07:34:58 +0000 Date: Sun, 22 May 2022 00:34:58 -0700 From: Christoph Hellwig To: Stefan Roesch Cc: io-uring@vger.kernel.org, kernel-team@fb.com, linux-mm@kvack.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, david@fromorbit.com, jack@suse.cz, hch@infradead.org Subject: Re: [RFC PATCH v4 16/17] xfs: Add async buffered write support Message-ID: References: <20220520183646.2002023-1-shr@fb.com> <20220520183646.2002023-17-shr@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220520183646.2002023-17-shr@fb.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 5DBFE1A0016 X-Rspam-User: Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=EwTBzO6R; spf=none (imf19.hostedemail.com: domain of BATV+c9e7f944c22607b8b784+6846+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+c9e7f944c22607b8b784+6846+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none X-Stat-Signature: jj4zmmcfofn66df88gzb7xnfbnbu81qx X-HE-Tag: 1653204889-200945 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, May 20, 2022 at 11:36:45AM -0700, Stefan Roesch wrote: > This adds the async buffered write support to XFS. For async buffered > write requests, the request will return -EAGAIN if the ilock cannot be > obtained immediately. > > This splits off a new helper xfs_ilock_inode from the existing helper > xfs_ilock_iocb so it can be used for this function. The exising helper > cannot be used as it hardcoded the inode to be used. Actually this should also be a prep patch - but the please try to follow the rule that standalone enablement like refactoring or new funtionality for helpers is one patch, the actual use of it for a new feature should preferably one patch for the whole feature.