From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 064A6C43334 for ; Mon, 6 Jun 2022 07:50:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 915268D000D; Mon, 6 Jun 2022 03:50:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8C7D88D0009; Mon, 6 Jun 2022 03:50:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7B2388D000D; Mon, 6 Jun 2022 03:50:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 67F4C8D0009 for ; Mon, 6 Jun 2022 03:50:20 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id 42F2A1205EA for ; Mon, 6 Jun 2022 07:50:20 +0000 (UTC) X-FDA: 79547038200.01.20D5272 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf26.hostedemail.com (Postfix) with ESMTP id 2076614002C for ; Mon, 6 Jun 2022 07:50:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=HPxHfG/UDxYj0oyJrzzEbK9o4LGHULeUwDrGsln6nJ0=; b=l86XAKhUWNGhIFaLw0lQV9B3IH WxUjDPk3Xsa0F1oUwNdgazNtu+z98w/Ybo1JCpWphHo2DDAw+XETdERrsD5RZNoVsWRikF1xjGDUY 3V3sz883b4fH21ZoY7JFU1/sPyiRPhzTDBirUZibgFLt3ddPM9/HcrIVPhLx4ugtRtD1m5jKdtPhx Il2PDQ42+0210Ffv7KYmRc9ocCx0oy61LeMab42M8/90f8sithyIQJtAlhByLYSwGFUbGnchIa6Ue 2a55iC8fe+XWjpdZbouAz+p4+ibIEhYl0XTqvLjR/eIxFdtLFBikK0pjK6v7tKrtbIPL0M0uZf5ZN Rs8K2TGQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1ny7V8-00HZxE-Dc; Mon, 06 Jun 2022 07:50:14 +0000 Date: Mon, 6 Jun 2022 00:50:14 -0700 From: Christoph Hellwig To: Kefeng Wang Cc: catalin.marinas@arm.com, will@kernel.org, akpm@linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, hch@infradead.org, arnd@arndb.de, anshuman.khandual@arm.com Subject: Re: [PATCH v4 2/6] mm: ioremap: Use more sensibly name in ioremap_prot() Message-ID: References: <20220606074815.139265-1-wangkefeng.wang@huawei.com> <20220606074815.139265-3-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220606074815.139265-3-wangkefeng.wang@huawei.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Stat-Signature: h8xanyggcaz14hn1y8a19wt64y75ys6y X-Rspam-User: Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=l86XAKhU; spf=none (imf26.hostedemail.com: domain of BATV+e288ad521791baeeb4bb+6861+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+e288ad521791baeeb4bb+6861+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 2076614002C X-HE-Tag: 1654501815-664524 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 06, 2022 at 03:48:11PM +0800, Kefeng Wang wrote: > Use more meaningful and sensibly naming phys_addr > instead addr in ioremap_prot(). > > Suggested-by: Andrew Morton > Reviewed-by: Anshuman Khandual > Signed-off-by: Kefeng Wang > --- > include/asm-generic/io.h | 2 +- > mm/ioremap.c | 12 ++++++------ > 2 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/include/asm-generic/io.h b/include/asm-generic/io.h > index 7ce93aaf69f8..e6ffa2519f08 100644 > --- a/include/asm-generic/io.h > +++ b/include/asm-generic/io.h > @@ -964,7 +964,7 @@ static inline void iounmap(volatile void __iomem *addr) > #elif defined(CONFIG_GENERIC_IOREMAP) > #include > > -void __iomem *ioremap_prot(phys_addr_t addr, size_t size, unsigned long prot); > +void __iomem *ioremap_prot(phys_addr_t phys_addr, size_t size, unsigned long prot); This adds an overly long line now. > -void __iomem *ioremap_prot(phys_addr_t addr, size_t size, unsigned long prot) > +void __iomem *ioremap_prot(phys_addr_t phys_addr, size_t size, unsigned long prot) Same here.