From: Christoph Hellwig <hch@infradead.org>
To: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: Christoph Hellwig <hch@infradead.org>,
catalin.marinas@arm.com, will@kernel.org,
akpm@linux-foundation.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org, arnd@arndb.de,
anshuman.khandual@arm.com
Subject: Re: [PATCH v4 5/6] arm64: mm: Convert to GENERIC_IOREMAP
Date: Mon, 6 Jun 2022 09:28:10 -0700 [thread overview]
Message-ID: <Yp4rGsj0eFcGRMmC@infradead.org> (raw)
In-Reply-To: <7a8f19b5-f22e-83be-0f9a-63cef6152812@huawei.com>
On Mon, Jun 06, 2022 at 09:28:22PM +0800, Kefeng Wang wrote:
> As commit bdc48fa11e46 ("checkpatch/coding-style: deprecate 80-column
> warning") increased
>
> the limit to 100 columns，so I don't get warning when using checkpatch, and
> it is not a hard limit,
No, it did not increase the general limit, just for exception cases.
Block comments certainly don't fall under that, and while the mileage
on the defineѕ may vary it generally is more readable to have them
on the next line.
checkpath is unfortunately totall broken these days :(
>
> but if this is a mandatory requirement, I will resend them with break lines.
>
> > > +#define ioremap_cache(addr, size) ({ \
> > > + pfn_is_map_memory(__phys_to_pfn(addr)) ? \
> > > + (void __iomem *)__phys_to_virt(addr) : ioremap_prot(addr, size, PROT_NORMAL); \
> > > +})
> > And this really should be an inline function.
>
> We still need a define, see kernel/iomem.c,
You can just define it to the same name after the inline.
next prev parent reply other threads:[~2022-06-06 16:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-06 7:48 [PATCH v4 0/6] arm64: Cleanup ioremap() and support ioremap_prot() Kefeng Wang
2022-06-06 7:48 ` [PATCH v4 1/6] ARM: mm: kill unused runtime hook arch_iounmap() Kefeng Wang
2022-06-06 7:49 ` Christoph Hellwig
2022-06-06 7:48 ` [PATCH v4 2/6] mm: ioremap: Use more sensibly name in ioremap_prot() Kefeng Wang
2022-06-06 7:50 ` Christoph Hellwig
2022-06-06 7:48 ` [PATCH v4 3/6] mm: ioremap: Setup phys_addr of struct vm_struct Kefeng Wang
2022-06-06 7:48 ` [PATCH v4 4/6] mm: ioremap: Add ioremap/iounmap_allowed() Kefeng Wang
2022-06-06 7:50 ` Christoph Hellwig
2022-06-06 15:14 ` Baoquan He
2022-06-07 7:37 ` Kefeng Wang
2022-06-06 7:48 ` [PATCH v4 5/6] arm64: mm: Convert to GENERIC_IOREMAP Kefeng Wang
2022-06-06 7:54 ` Christoph Hellwig
2022-06-06 13:28 ` Kefeng Wang
2022-06-06 16:28 ` Christoph Hellwig [this message]
2022-06-06 17:41 ` kernel test robot
2022-06-06 7:48 ` [PATCH v4 6/6] arm64: Add HAVE_IOREMAP_PROT support Kefeng Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yp4rGsj0eFcGRMmC@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=wangkefeng.wang@huawei.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).