From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FAE3C43334 for ; Mon, 6 Jun 2022 16:28:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A42DE8D0007; Mon, 6 Jun 2022 12:28:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9C5AC8D0005; Mon, 6 Jun 2022 12:28:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 88B5A8D0007; Mon, 6 Jun 2022 12:28:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 765CF8D0005 for ; Mon, 6 Jun 2022 12:28:30 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 2C420209AA for ; Mon, 6 Jun 2022 16:28:30 +0000 (UTC) X-FDA: 79548343980.16.F6675B8 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf15.hostedemail.com (Postfix) with ESMTP id F2C94A0005 for ; Mon, 6 Jun 2022 16:28:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Transfer-Encoding :Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=ySO04BQMERNCntShqOb8/rNfxsKhEd7ILgGbDAOV4w0=; b=H6WifuO0/6N7vAHH54RYwAlnqo Hyluy/Ch1n37hU2m3hG5j12KRTvuxPdcJQTeCPU29Du3eK2gP5gOm/bzEhTS0PrPzmAwq1HfeQZkY qBsSPwSDwoa7IdAQocgBFZZvqw60famOZ426duHRmHEhwZTmghgOExqFS1jMPz/6eCQvlyh/sKUZ+ CViWhH7nEU7NVedIywrkFR/H2ZyG57V4ex5PtkgV1ADfrK8WA52ayevSsY8O7NPSdvvPTFfrrai3J FvN67L5wuD+tPVtOYfMfsWogMK0836TJvomfeAmHv3EAgIKi3RdKpecNtzIoihMedyOg1ClCjfuDd p/sSeGsw==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nyFaM-0022H0-HN; Mon, 06 Jun 2022 16:28:10 +0000 Date: Mon, 6 Jun 2022 09:28:10 -0700 From: Christoph Hellwig To: Kefeng Wang Cc: Christoph Hellwig , catalin.marinas@arm.com, will@kernel.org, akpm@linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, arnd@arndb.de, anshuman.khandual@arm.com Subject: Re: [PATCH v4 5/6] arm64: mm: Convert to GENERIC_IOREMAP Message-ID: References: <20220606074815.139265-1-wangkefeng.wang@huawei.com> <20220606074815.139265-6-wangkefeng.wang@huawei.com> <7a8f19b5-f22e-83be-0f9a-63cef6152812@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7a8f19b5-f22e-83be-0f9a-63cef6152812@huawei.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: F2C94A0005 X-Stat-Signature: w9p89nuxnq6thzxrkxh1df36jiyhxxmh X-Rspam-User: Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=H6WifuO0; spf=none (imf15.hostedemail.com: domain of BATV+e288ad521791baeeb4bb+6861+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+e288ad521791baeeb4bb+6861+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none X-HE-Tag: 1654532882-693960 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 06, 2022 at 09:28:22PM +0800, Kefeng Wang wrote: > As commit bdc48fa11e46  ("checkpatch/coding-style: deprecate 80-column > warning") increased > > the limit to 100 columns，so I don't get warning when using checkpatch, and > it is not a hard limit, No, it did not increase the general limit, just for exception cases. Block comments certainly don't fall under that, and while the mileage on the defineѕ may vary it generally is more readable to have them on the next line. checkpath is unfortunately totall broken these days :( > > but if this is a mandatory requirement, I will resend them with break lines. > > > > +#define ioremap_cache(addr, size) ({ \ > > > + pfn_is_map_memory(__phys_to_pfn(addr)) ? \ > > > + (void __iomem *)__phys_to_virt(addr) : ioremap_prot(addr, size, PROT_NORMAL); \ > > > +}) > > And this really should be an inline function. > > We still need a define, see kernel/iomem.c, You can just define it to the same name after the inline.