linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Baoquan He <bhe@redhat.com>
Cc: akpm@linux-foundation.org, npiggin@gmail.com, urezki@gmail.com,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/5] mm: ioremap: rename ioremap_page_range() to ioremap_range()
Date: Mon, 6 Jun 2022 22:27:44 -0700	[thread overview]
Message-ID: <Yp7h0Jv6vpgt6xdZ@infradead.org> (raw)
In-Reply-To: <20220606083909.363350-6-bhe@redhat.com>

On Mon, Jun 06, 2022 at 04:39:09PM +0800, Baoquan He wrote:
> Because the current ioremap_page_range() only maps IO address to kernel
> virtual address, no struct page pointer passed in or page handling related.
> So rename it here.
> 
> The renaming is done with below command:
> sed -i "s/ioremap_page_range/ioremap_range/g" `git grep -l ioremap_page_range`

This creates a lot of churn without much of a benefit.  If you want
to get rid of the name please convert most architectures to the
generioc ioremap code first so that all these callers go away..



  reply	other threads:[~2022-06-07  5:27 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-06  8:39 [PATCH 0/5] Cleanup patches of vmalloc Baoquan He
2022-06-06  8:39 ` [PATCH 1/5] mm/vmalloc: remove the unnecessary type check Baoquan He
2022-06-06 20:36   ` Uladzislau Rezki
2022-06-06 23:34     ` Baoquan He
2022-06-06  8:39 ` [PATCH 2/5] mm/vmalloc: remove the redundant boundary check Baoquan He
2022-06-06 20:46   ` Uladzislau Rezki
2022-06-06  8:39 ` [PATCH 3/5] mm/vmalloc: fix typo in local variable name Baoquan He
2022-06-06 20:47   ` Uladzislau Rezki
2022-06-06  8:39 ` [PATCH 4/5] mm/vmalloc: Add code comment for find_vmap_area_exceed_addr() Baoquan He
2022-06-06 20:50   ` Uladzislau Rezki
2022-06-06  8:39 ` [PATCH 5/5] mm: ioremap: rename ioremap_page_range() to ioremap_range() Baoquan He
2022-06-07  5:27   ` Christoph Hellwig [this message]
2022-06-07  7:53     ` Baoquan He

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yp7h0Jv6vpgt6xdZ@infradead.org \
    --to=hch@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=bhe@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=npiggin@gmail.com \
    --cc=urezki@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).