From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6003C433F5 for ; Sat, 28 May 2022 05:49:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 41E7B8D0006; Sat, 28 May 2022 01:49:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3CA838D0001; Sat, 28 May 2022 01:49:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2DF338D0006; Sat, 28 May 2022 01:49:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 204748D0001 for ; Sat, 28 May 2022 01:49:11 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id E64D460D8D for ; Sat, 28 May 2022 05:49:10 +0000 (UTC) X-FDA: 79514073660.07.FCABB23 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf16.hostedemail.com (Postfix) with ESMTP id 52CB918002C for ; Sat, 28 May 2022 05:48:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=7tlyWYj50jjriKdh8WZL0X1UuZpv8+ldNsw5zcN/4rw=; b=b4UcQ8Rd3xMBHwYRDX6kukq/gc amdR56H423GoNPm/mH5JsWVrPgc1MFNFQCsShDnfBA03bEMwKx0VRmM4xFkEXUqQnWe/JzLUSugbS Kbr4A6anQjQeUiDen3tIkaxqhLgLY8KRTk39lw8RQwfO5u2fPxXP/JWOcrWnNckUH0kRh8qmOS5xz CQ56alunemZ9zZE+8bvqHode72AVm70Lb9rgIgrpciOpAPXoD5uIvnHDSwsJSzb7rNiNLbXu8wPC3 EUMpYbP2PkRyKlPi+fVPq4ilnmCY7vs3afNBnpZdwzcv13ifsl9Md50bzCs9ON8yQ5T5N7zH12qc4 AilaB+cA==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nupK0-001VSA-9U; Sat, 28 May 2022 05:49:08 +0000 Date: Fri, 27 May 2022 22:49:08 -0700 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 08/24] ext2: Remove check for PageError Message-ID: References: <20220527155036.524743-1-willy@infradead.org> <20220527155036.524743-9-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220527155036.524743-9-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: 52CB918002C X-Rspam-User: Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=b4UcQ8Rd; spf=none (imf16.hostedemail.com: domain of BATV+c5e11ba0f85895bf2855+6852+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+c5e11ba0f85895bf2855+6852+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none X-Stat-Signature: sxmqe6uwtg8rmgkh5r4kahpk5mdtwmzu X-Rspamd-Server: rspam05 X-HE-Tag: 1653716935-394697 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, May 27, 2022 at 04:50:20PM +0100, Matthew Wilcox (Oracle) wrote: > If read_mapping_page() encounters an error, it returns an errno, not a > page with PageError set, so this test is not needed. Looks good: Reviewed-by: Christoph Hellwig