From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64891C433F5 for ; Sat, 28 May 2022 05:49:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 05D758D0003; Sat, 28 May 2022 01:49:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0109B8D0001; Sat, 28 May 2022 01:49:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E3CB98D0003; Sat, 28 May 2022 01:49:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id D6F228D0001 for ; Sat, 28 May 2022 01:49:22 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id B01F9609FE for ; Sat, 28 May 2022 05:49:22 +0000 (UTC) X-FDA: 79514074164.16.D322B95 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf31.hostedemail.com (Postfix) with ESMTP id DE9162004A for ; Sat, 28 May 2022 05:48:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=sNf6V5APhdWYjUjlBBfjBB6dn815d19Xny6vDUcgK1g=; b=VN2kHnfx9HLxEk+Vd2IcT0Q6xY E77xSCJQ+pDrL5sQwy1+rsFepkYeVe4/8y/W5Q/m9uUwbeN8SQ73hphsCjHBFqhN9oH+z9Tq7Mzub SZ9aOKKIpkftnxGvcCdmp6ggbmh7smt4RUXwBdWztJfQLvom4lmetzwgRQHRhqq8dsbumf2Jys8LN b312KTYmCvXZTcKeMEkyqINJSeMij+TBnHIg1IMPfCb6A8x5FH2S8xvXYwWzepQVjB9R81poynfsT Khv6i+7dVzNM7cg9MjNMOTKsMVtiwR8KEb3sV82b8fgwAc8JMHRLrJ1F/BokN9sDGP5vD9xcWmS44 MsKycPaA==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nupKC-001VV1-6s; Sat, 28 May 2022 05:49:20 +0000 Date: Fri, 27 May 2022 22:49:20 -0700 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 09/24] nilfs2: Remove check for PageError Message-ID: References: <20220527155036.524743-1-willy@infradead.org> <20220527155036.524743-10-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220527155036.524743-10-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Stat-Signature: fm47jjqiryykpyefrxprpnckyteggbry X-Rspam-User: Authentication-Results: imf31.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=VN2kHnfx; spf=none (imf31.hostedemail.com: domain of BATV+c5e11ba0f85895bf2855+6852+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+c5e11ba0f85895bf2855+6852+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: DE9162004A X-HE-Tag: 1653716924-859259 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, May 27, 2022 at 04:50:21PM +0100, Matthew Wilcox (Oracle) wrote: > If read_mapping_page() encounters an error, it returns an errno, not a > page with PageError set, so this test is not needed. Looks good: Reviewed-by: Christoph Hellwig