From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1E8EC433EF for ; Sat, 28 May 2022 05:47:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 14C7D8D0003; Sat, 28 May 2022 01:47:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0D9788D0001; Sat, 28 May 2022 01:47:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F2B838D0003; Sat, 28 May 2022 01:47:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id DF34F8D0001 for ; Sat, 28 May 2022 01:47:29 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 8E0DAC66 for ; Sat, 28 May 2022 05:47:29 +0000 (UTC) X-FDA: 79514069418.24.D756699 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf31.hostedemail.com (Postfix) with ESMTP id 1797D2004A for ; Sat, 28 May 2022 05:46:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=mONrJIgsC+ftVFSvdH1KiA8xTtfiFd2tBeS46w9EXC4=; b=k0rmMFDk31kEqtqq3nrJCaXpDq s3Dql5xGlltV5WjEdwBaK7h1OltYEM/6ysHUHI7mHfLStY6bEK9Yeio3jZyFp03OhFwQNTFQgEXVe cB0UiUfW4j7wtB+ZQkmqobIjHHq9qgpAtybExT0NhNcG4yEPXCWFL1JvDXuqQI5lFLn3zsmqYrCMi LmDf1OxaHysZohmHUrTESVyuCOPyTHfKBiucrNQomko3gJjqcNLmxCPG6ylAVm+CmqFXtrscT5S6Z yMlBrtrYaNtH/khEDLBEnPK0Ea2F8YnkfsH7DiZyrxEFmQu1CUk0Vuxp7KP9xUFQwyu0xKt17RSc0 gbJPHcjQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nupIK-001VCm-KV; Sat, 28 May 2022 05:47:24 +0000 Date: Fri, 27 May 2022 22:47:24 -0700 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 01/24] block: Remove check of PageError Message-ID: References: <20220527155036.524743-1-willy@infradead.org> <20220527155036.524743-2-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220527155036.524743-2-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Rspamd-Queue-Id: 1797D2004A X-Stat-Signature: i8rdzbdamuczzg5y1urkf6iecaeaixcx Authentication-Results: imf31.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=k0rmMFDk; spf=none (imf31.hostedemail.com: domain of BATV+c5e11ba0f85895bf2855+6852+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+c5e11ba0f85895bf2855+6852+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none X-Rspamd-Server: rspam09 X-HE-Tag: 1653716810-611084 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, May 27, 2022 at 04:50:13PM +0100, Matthew Wilcox (Oracle) wrote: > If read_mapping_page() sees a page with PageError set, it returns a > PTR_ERR(). Checking PageError again is simply dead code. Looks good: Reviewed-by: Christoph Hellwig