From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77D08C433F5 for ; Sat, 28 May 2022 05:47:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 06BE88D0005; Sat, 28 May 2022 01:47:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F395A8D0001; Sat, 28 May 2022 01:47:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E232F8D0005; Sat, 28 May 2022 01:47:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D334D8D0001 for ; Sat, 28 May 2022 01:47:42 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id AA49360B7C for ; Sat, 28 May 2022 05:47:42 +0000 (UTC) X-FDA: 79514069964.16.4E1C9F9 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf19.hostedemail.com (Postfix) with ESMTP id 967041A0039 for ; Sat, 28 May 2022 05:47:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=i1Lvs5BpBAXbau72zrMflW/NuAghVvwBlqUp2VoYfDg=; b=DuWqu8ADAlU20TOePAdGh7svOI jAF0A9x37nSvEGHDNQdgfU0Y8ykpR/OEeba6sXVFJ0YtS8gyfV1rOBsGMs+JRENTRg2ty37ArDN34 wVN+CB3wFoIpzlKVgFwjc8huvtSRKuNaJZZnaQ1keR0JgA6zS95STnknKT5o6nJdDWCa7LSgTU6ax vIHFESy2HR1MZaNs9et/AXACwfqnlbNCvxgLN8qEu7Nr/+a58jnAwdXoQrxE8zGZnOUcqp+OTLCQa KrrcClXkWyFPg9MjJfULOa7BCG5BeRAyggEcF8ejG3tvM+nvPGdROFcq290KOsWFmtwoBiuHZD4R9 bcxt+jsQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nupIZ-001VEj-W3; Sat, 28 May 2022 05:47:40 +0000 Date: Fri, 27 May 2022 22:47:39 -0700 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 02/24] afs: Remove check of PageError Message-ID: References: <20220527155036.524743-1-willy@infradead.org> <20220527155036.524743-3-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220527155036.524743-3-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 967041A0039 X-Stat-Signature: b1e88pjmuqmfmiq9i8nwwn7cri7cs4rr Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=DuWqu8AD; dmarc=none; spf=none (imf19.hostedemail.com: domain of BATV+c5e11ba0f85895bf2855+6852+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+c5e11ba0f85895bf2855+6852+infradead.org+hch@bombadil.srs.infradead.org X-Rspam-User: X-HE-Tag: 1653716848-115740 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, May 27, 2022 at 04:50:14PM +0100, Matthew Wilcox (Oracle) wrote: > If read_mapping_page() encounters an error, it returns an errno, not a > page with PageError set, so this is dead code. Looks good: Reviewed-by: Christoph Hellwig