From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C6B6C433EF for ; Sat, 28 May 2022 05:48:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EE1ED8D0006; Sat, 28 May 2022 01:48:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E95198D0001; Sat, 28 May 2022 01:48:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D7EF98D0006; Sat, 28 May 2022 01:48:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id C98278D0001 for ; Sat, 28 May 2022 01:48:10 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 9AEACAFC for ; Sat, 28 May 2022 05:48:10 +0000 (UTC) X-FDA: 79514071140.10.11A1884 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf25.hostedemail.com (Postfix) with ESMTP id 450F4A0035 for ; Sat, 28 May 2022 05:47:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ROhb8fpAaS6Hhw6CtsoNTNucFXDZkX7H+gk7MOZT5xk=; b=oYj8STEdM+ldPMkDb3v9Iqjzrd 7PW22OjjAVzuvP5vKWL9/03Sw272RYCs5tLkI6lK0K4XkqZIFkLy86Q87x/yuVLni4H4iutV72533 F/B5WoY+r1S0JuemTPOWmnKopchKYgm7D4Q2F/dgcX8JxCWd28HKy/t0br3tySPL6X6KPsCgT0vZP guZeQpN2U9tMvllLV8cg1NDZ3I+SqA0Ogh6+3tNzztfxEO9y8jlAkZ9TImRi+ldU8vDFCm5thMm4I 7NUt5q0LghxDRY7k3ImyQIMtNNvenYwpbZbb9cesoYL53A4LnF0KDcQtBHeUI4wEspKYznC/sajFB FeU0jFKA==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nupJ1-001VI0-Ql; Sat, 28 May 2022 05:48:07 +0000 Date: Fri, 27 May 2022 22:48:07 -0700 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 03/24] freevxfs: Remove check of PageError Message-ID: References: <20220527155036.524743-1-willy@infradead.org> <20220527155036.524743-4-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220527155036.524743-4-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Rspamd-Queue-Id: 450F4A0035 X-Stat-Signature: skpsyeakhxgcresm14o7o5sgjcawp7wn Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=oYj8STEd; spf=none (imf25.hostedemail.com: domain of BATV+c5e11ba0f85895bf2855+6852+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+c5e11ba0f85895bf2855+6852+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none X-Rspamd-Server: rspam09 X-HE-Tag: 1653716859-528814 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > /** if (!PageChecked(pp)) **/ > /** vxfs_check_page(pp); **/ > - if (PageError(pp)) > - goto fail; Can you remove this comment out code as well while you're at it? Otherwise looks good: Reviewed-by: Christoph Hellwig