From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3BC6C433F5 for ; Sat, 28 May 2022 05:52:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 73BA08D0005; Sat, 28 May 2022 01:52:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6EB098D0001; Sat, 28 May 2022 01:52:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5FFD18D0005; Sat, 28 May 2022 01:52:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 531B58D0001 for ; Sat, 28 May 2022 01:52:17 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 346A120D3B for ; Sat, 28 May 2022 05:52:17 +0000 (UTC) X-FDA: 79514081514.18.1897F03 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf02.hostedemail.com (Postfix) with ESMTP id F0B6980042 for ; Sat, 28 May 2022 05:52:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=KmqNJ6E2qsxHF9GpvNIzcsovm7YlBdqPdFhTr3BZhlo=; b=oWM5PbXdfLYYrvc/5k8whG0dS7 3JGdjRxHOfuO9uZT0Y6X+lC2A+xZ0qzKaX/EKjW5NRSDB/8pcWS2q/YGAE7fb7kvmPqG9p6vzXfMt 9t9O6Pd2vaU4ni43ahiuMSrGVor4OMHIAAH+xxiyTwtBwB/ApOHS9iHnp8YeMQwhy5pm+NQZ3n/Nu Kcc/ezfokXacd0PIdz8gB98YM5zwB/zJwqR2E8Uj2zx2HAa5FEac1Mmm0xqi5rR/E5oEBQn69KtSV 9RsWnGM79Ci22imJb+7XpdVALX/+4KfbckiYx5P3jHrykvoYP253LPuKCpKG3pmXpzPu+3Vv8RVa3 qmDCBnUA==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nupN1-001VuF-0q; Sat, 28 May 2022 05:52:15 +0000 Date: Fri, 27 May 2022 22:52:15 -0700 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 12/24] reiserfs: Remove check for PageError Message-ID: References: <20220527155036.524743-1-willy@infradead.org> <20220527155036.524743-13-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220527155036.524743-13-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=oWM5PbXd; dmarc=none; spf=none (imf02.hostedemail.com: domain of BATV+c5e11ba0f85895bf2855+6852+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+c5e11ba0f85895bf2855+6852+infradead.org+hch@bombadil.srs.infradead.org X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: F0B6980042 X-Stat-Signature: c9ugqgmddggfnusahsebn59bbf6itoxm X-HE-Tag: 1653717132-932632 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, May 27, 2022 at 04:50:24PM +0100, Matthew Wilcox (Oracle) wrote: > If read_mapping_page() encounters an error, it returns an errno, not a > page with PageError set, so this is dead code. Looks good: Reviewed-by: Christoph Hellwig