From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D43B2C433F5 for ; Sat, 28 May 2022 06:02:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 74E0E8D0005; Sat, 28 May 2022 02:02:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6FB1A8D0001; Sat, 28 May 2022 02:02:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5E78F8D0005; Sat, 28 May 2022 02:02:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 4DD1C8D0001 for ; Sat, 28 May 2022 02:02:13 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 23CBA35C2A for ; Sat, 28 May 2022 06:02:13 +0000 (UTC) X-FDA: 79514106546.28.06100E7 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf18.hostedemail.com (Postfix) with ESMTP id A0D171C0035 for ; Sat, 28 May 2022 06:01:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=uYXzrV+DtoSk9kPAECiILCkfcPpXNMD+fuOQxUK/giM=; b=o96qohAr4yUHhzyQ7b4NxMnnEM JXeKjp5f4cMQxoAnRzFzPWOlGIWwd07TDB2w3OUCBtbwrjmFsB6cyCd/KZFrnWPbIGupjM/b4df3V KfJ+xTDN+MPHuNxzbLA1WWIQTDh4Jzh4ABA69521o/gi4BP5yzrhSuS1PgFpGrz7OEVdV6tcwaqnx 8a7XAd7yNjZTZI2w6AaAAQ2oToQ5iufIm1N7SXmbK9pKdpEH1fOxKqbNpnnJlcbimG9mo45RtjBYM ul79d0qks7rr1b4dpAyxPzt/MFJmEpJqiBjQeIupJaI4+XYZ4TnbmbCBJiKeOs/BjvkiWOX2s7J6M kDSZt/XQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nupWc-001Wtw-5T; Sat, 28 May 2022 06:02:10 +0000 Date: Fri, 27 May 2022 23:02:10 -0700 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 19/24] nfs: Leave pages in the pagecache if readpage failed Message-ID: References: <20220527155036.524743-1-willy@infradead.org> <20220527155036.524743-20-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220527155036.524743-20-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: A0D171C0035 X-Stat-Signature: yyz9wwfbp6437p39mg9wez9uujih8nit Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=o96qohAr; dmarc=none; spf=none (imf18.hostedemail.com: domain of BATV+c5e11ba0f85895bf2855+6852+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+c5e11ba0f85895bf2855+6852+infradead.org+hch@bombadil.srs.infradead.org X-HE-Tag: 1653717714-718048 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, May 27, 2022 at 04:50:31PM +0100, Matthew Wilcox (Oracle) wrote: > The pagecache handles readpage failing by itself; it doesn't want > filesystems to remove pages from under it. This looks sesible to me, but please Cc thisto the NFS list or maintainers, it might be worth to dig out the history and possibly test cases for it.