From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87484C433EF for ; Sat, 28 May 2022 05:59:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 240D38D0003; Sat, 28 May 2022 01:59:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1CC408D0001; Sat, 28 May 2022 01:59:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0901B8D0003; Sat, 28 May 2022 01:59:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id EA2518D0001 for ; Sat, 28 May 2022 01:59:07 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id C501EAE1 for ; Sat, 28 May 2022 05:59:07 +0000 (UTC) X-FDA: 79514098734.22.177BC91 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf26.hostedemail.com (Postfix) with ESMTP id 65D05140036 for ; Sat, 28 May 2022 05:59:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=smPADnsVR5YDwQtqHwKgF9tayL1Q4tQ+CZz+VEL3i4U=; b=Gdj0VhFRWnWj2dvIQlRscq5VNW 7dMJpkOiPCj39OFBDuSEqU1TqDuM1u0Xht8UIG77Y98yLLA9JZa9vq4M6t1C98nTHcXecaqqhCtjd 6ZxGQc0BbitqxRdgadkEG4L88vQkGtApLEhCI53sSS8/bYMbyMYS+HFMOFaTkg7Jd1eMI65BuhItm +ovfNUff5wd4XwY2lGuDAtN8Ei6GryN3DVhhv8V+fdyS+Vh4m9jMg2JiAJYWjeZPv4V0JO7e/yI4d xVjySOa26twfLzcdJrboKt4fJhbfSLNLc0UxjbAvpKhUQKOucSIS1V93il0yu2iobt21eu0/9XoFy /04nmbvg==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nupTb-001Wa2-RW; Sat, 28 May 2022 05:59:03 +0000 Date: Fri, 27 May 2022 22:59:03 -0700 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 14/24] remap_range: Remove check of uptodate flag Message-ID: References: <20220527155036.524743-1-willy@infradead.org> <20220527155036.524743-15-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220527155036.524743-15-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: 65D05140036 X-Rspam-User: Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=Gdj0VhFR; spf=none (imf26.hostedemail.com: domain of BATV+c5e11ba0f85895bf2855+6852+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+c5e11ba0f85895bf2855+6852+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none X-Stat-Signature: mjga5sf8sxqtdynqkhxn1myuuddg7dzk X-Rspamd-Server: rspam05 X-HE-Tag: 1653717543-250103 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, May 27, 2022 at 04:50:26PM +0100, Matthew Wilcox (Oracle) wrote: > read_mapping_folio() returns an ERR_PTR if the folio is not > uptodate, so this check is simply dead code. Looks good: Reviewed-by: Christoph Hellwig > /* Read a page's worth of file data into the page cache. */ > static struct folio *vfs_dedupe_get_folio(struct file *file, loff_t pos) > { > + return read_mapping_folio(file->f_mapping, pos >> PAGE_SHIFT, file); > } But I wonder if this isn't useful enough to go to filemap.c in one form or another.