From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D868FC433EF for ; Sat, 28 May 2022 06:00:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5D3838D0003; Sat, 28 May 2022 02:00:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 582838D0001; Sat, 28 May 2022 02:00:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 494AA8D0003; Sat, 28 May 2022 02:00:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 3DA7A8D0001 for ; Sat, 28 May 2022 02:00:30 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 149E4A7F for ; Sat, 28 May 2022 06:00:30 +0000 (UTC) X-FDA: 79514102220.06.C417B9F Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf31.hostedemail.com (Postfix) with ESMTP id 4AF752005E for ; Sat, 28 May 2022 05:59:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=dNey4vA+3fR/UAM+M+UFSsVzwmKTtoszlzMQg3hwkYE=; b=qqEpBeY5gZpjtbLey2DsvJIXg1 X6lD0JBn1tW8k7Z11sdHQwtEdGJjlijBpQ+Gcq8wkJgD1ZI9weW4vxdBG09OEWsIYN9pXThplYXRe VTxWLq/Ri+Qo0tc8c/iil55zCGCxzvXN7zR4eggEcxrT8rpZ3SoEqUo9VdKn6BSWGqOSdajwY2gGR XWZxHuU3DQRUCDSOOU7uReDagcxWT1xULJ+EXqtLeHhIC4Dn2xbM4wfYZm15hdEW+ZlShJjeQgJO/ Lcq1H+Ds5VhzwvgRj3GjwNSuXtSgE/TwowotDcQT3PNqzbeB8+rj9KOA1pW9Tcro1CKlwV7EiBC6R 93PAXolw==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nupUx-001Wj4-7g; Sat, 28 May 2022 06:00:27 +0000 Date: Fri, 27 May 2022 23:00:27 -0700 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 16/24] iomap: Remove test for folio error Message-ID: References: <20220527155036.524743-1-willy@infradead.org> <20220527155036.524743-17-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220527155036.524743-17-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 4AF752005E X-Stat-Signature: j49yuxtf5xef3j8okg1puz36wce8jre4 Authentication-Results: imf31.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=qqEpBeY5; dmarc=none; spf=none (imf31.hostedemail.com: domain of BATV+c5e11ba0f85895bf2855+6852+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+c5e11ba0f85895bf2855+6852+infradead.org+hch@bombadil.srs.infradead.org X-Rspam-User: X-HE-Tag: 1653717592-718682 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, May 27, 2022 at 04:50:28PM +0100, Matthew Wilcox (Oracle) wrote: > Just because there has been a read error doesn't mean we should avoid > marking this part of the folio as uptodate. Indeed, it may overwrite > the error part of the folio and let us mark the entire folio uptodate. This does look sensible, but I'm a little worried about this area. Did this survive an xfstests run with a sub-pagesize blocksize file system?