From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86256C433EF for ; Sat, 28 May 2022 06:00:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 14A4E8D0005; Sat, 28 May 2022 02:00:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0F9DB8D0001; Sat, 28 May 2022 02:00:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F25928D0005; Sat, 28 May 2022 02:00:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id E51E88D0001 for ; Sat, 28 May 2022 02:00:47 -0400 (EDT) Received: from smtpin31.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id C1CC335D24 for ; Sat, 28 May 2022 06:00:47 +0000 (UTC) X-FDA: 79514102934.31.998AD4A Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf28.hostedemail.com (Postfix) with ESMTP id 67E0EC004D for ; Sat, 28 May 2022 06:00:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=rsBwluTalEVbHJfHOGzLNIf+cV3Fyok2XI6tCmHheak=; b=yxP6XtN6wgPCNmVbAwWsjguXwa zq6eJQJ0TLgwdwcBRCBRDXeWcfn2sTgngKSV3gcaNRqodMSO6d5L8IzxoBeeE3ngZ+0uAkq0TuM/E O+uA1UICF9/DWAOg000I+YnclaN8gzTRyd+24BRhYtvaB4vD2G7Nu/YX/gSLyFL6mY+NYxheQfsjM 5WV+DBOmvTP11eec+vONg0CY4btX6Z5qkrFbMp2uMFANKxtl5QwJIRXx9KLXugJMzpZ6JEd9p8pmG HpEvpG63jriDkUQn0rztDMdJBhIO8nq9SDSmun8LeBmxkoflaLcHWOkoVtaqbYstzyg6GiUKXAL7m AMBVE+oA==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nupVF-001WlF-Is; Sat, 28 May 2022 06:00:45 +0000 Date: Fri, 27 May 2022 23:00:45 -0700 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 17/24] orangefs: Remove test for folio error Message-ID: References: <20220527155036.524743-1-willy@infradead.org> <20220527155036.524743-18-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220527155036.524743-18-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Stat-Signature: 7ry63sor3zc4fha51x7z846gf3jqsugu X-Rspam-User: Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=yxP6XtN6; spf=none (imf28.hostedemail.com: domain of BATV+c5e11ba0f85895bf2855+6852+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+c5e11ba0f85895bf2855+6852+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 67E0EC004D X-HE-Tag: 1653717612-21863 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, May 27, 2022 at 04:50:29PM +0100, Matthew Wilcox (Oracle) wrote: > The page cache clears the error bit before calling ->read_folio(), > so this condition could never have been true. Looks good: Reviewed-by: Christoph Hellwig