From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85D4DC433EF for ; Sat, 28 May 2022 06:01:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 253B68D0003; Sat, 28 May 2022 02:01:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1FE978D0001; Sat, 28 May 2022 02:01:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 113668D0003; Sat, 28 May 2022 02:01:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 00B9B8D0001 for ; Sat, 28 May 2022 02:01:07 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id CEC5480B9D for ; Sat, 28 May 2022 06:01:07 +0000 (UTC) X-FDA: 79514103774.16.CBEDAF5 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf21.hostedemail.com (Postfix) with ESMTP id 71B921C0049 for ; Sat, 28 May 2022 06:00:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=3CCidAfO7CDAY1Xeo0tE8eo2wKdVLimf36Fg6SjW3lU=; b=2dVVXsFtN0CgBJuFEZa0yrd/wK dQufcqzM7Bx5htW+oR6akqwBBmF0mUYsE2knqhCXUNaVy0tVAK4qOWoegMZX/OmaoLnpdAp2+cVWY 9r4RFxGDJbawVZvHdzluMAJ9lGB5/fqWY3p07hs7sIUNfyVc6WcV5n+wpGB60sPO9Flh8kfV47m6F 6JWk7K0iK5/x6fnhzZ4Fdztb62iebRdKb4YRNg2LF9yaqOpwNTrefy0xqTXgEukb3k2ut8RGsPwpH oBylObymPRoJ3x1jPSjaVHiLkyJJc8k4CDXOPp1K4IGkr5jXzmVEJZtDcAFFq3GoWBmXrpgSzYVHG RsY8B+Rw==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nupVZ-001WoY-Ji; Sat, 28 May 2022 06:01:05 +0000 Date: Fri, 27 May 2022 23:01:05 -0700 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 18/24] buffer: Remove check for PageError Message-ID: References: <20220527155036.524743-1-willy@infradead.org> <20220527155036.524743-19-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220527155036.524743-19-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=2dVVXsFt; dmarc=none; spf=none (imf21.hostedemail.com: domain of BATV+c5e11ba0f85895bf2855+6852+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+c5e11ba0f85895bf2855+6852+infradead.org+hch@bombadil.srs.infradead.org X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 71B921C0049 X-Stat-Signature: 5i7oody68admad65x4mew1eoj1mk94e1 X-HE-Tag: 1653717654-896483 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, May 27, 2022 at 04:50:30PM +0100, Matthew Wilcox (Oracle) wrote: > If a buffer is completed with an error, its uptodate flag will be clear, > so the page_uptodate variable will have been set to 0. There's no > need to check PageError here. > > Signed-off-by: Matthew Wilcox (Oracle) Looks good: Reviewed-by: Christoph Hellwig