From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 066EBC433FE for ; Sat, 28 May 2022 06:06:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 988E68D0003; Sat, 28 May 2022 02:06:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9142D8D0001; Sat, 28 May 2022 02:06:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 801BB8D0003; Sat, 28 May 2022 02:06:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 7469C8D0001 for ; Sat, 28 May 2022 02:06:13 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id 5BCEB60C29 for ; Sat, 28 May 2022 06:06:13 +0000 (UTC) X-FDA: 79514116626.29.CBCCB9C Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf27.hostedemail.com (Postfix) with ESMTP id 6258B40048 for ; Sat, 28 May 2022 06:06:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ikgu9SvRIibqXizppF6tmD+Q1abJ18DzQavcED7bHFU=; b=LQ26/G84G8OH6uhNcfpGi/XO2q /0ieiKTGykinEHPGm/w66SXN1mpBRrwaCtrrZKcm5+PSqnk7RG7wy/n12XnWGPWtylYj3HFfRXebG zg05gcOUPOxJ3BL32bPxdXPGR+zP4SJGxJ/qhPRmKB7Hy4yYNj4YjveZfECpQBsrgYcf8uMb1IjRv dcEywPaSww/H4Nt1rJOQPtj5jMTVCARMwJrYJGtn+koa6s3XXmQ4Bubam0Pz3q8ygEEpq9jKeRMZ7 WP7xFobLREorVezkfXGiw0cU+/sZ/hHy1ec1qN0Mx9u/6UGUD/84ZDtot3Suu3z69fRr6zu02XXT7 akVDlPfw==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nupaU-001XFu-U4; Sat, 28 May 2022 06:06:10 +0000 Date: Fri, 27 May 2022 23:06:10 -0700 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 22/24] squashfs: Return the actual error from squashfs_read_folio() Message-ID: References: <20220527155036.524743-1-willy@infradead.org> <20220527155036.524743-23-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220527155036.524743-23-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b="LQ26/G84"; dmarc=none; spf=none (imf27.hostedemail.com: domain of BATV+c5e11ba0f85895bf2855+6852+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+c5e11ba0f85895bf2855+6852+infradead.org+hch@bombadil.srs.infradead.org X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 6258B40048 X-Stat-Signature: 3drbxm1xsroeedb79fx631oqzkfy3nr4 X-HE-Tag: 1653717969-544261 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, May 27, 2022 at 04:50:34PM +0100, Matthew Wilcox (Oracle) wrote: > Since we actually know what error happened, we can report it instead > of having the generic code return -EIO for pages that were unlocked > without being marked uptodate. Also remove a test of PageError since > we have the return value at this point. Looks good: Reviewed-by: Christoph Hellwig