From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B921EC433F5 for ; Sat, 28 May 2022 06:06:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 598F08D0006; Sat, 28 May 2022 02:06:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 54BE28D0001; Sat, 28 May 2022 02:06:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4356F8D0006; Sat, 28 May 2022 02:06:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 368608D0001 for ; Sat, 28 May 2022 02:06:34 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 1033860E55 for ; Sat, 28 May 2022 06:06:34 +0000 (UTC) X-FDA: 79514117508.01.F70F0AD Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf29.hostedemail.com (Postfix) with ESMTP id D10C2120044 for ; Sat, 28 May 2022 06:06:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=/2jdyMFgby36iYA2MQTzDG6VGrzdDvl1K94LnTMG+Vg=; b=zxlEWezoZb9jLuvZz3tYRMfqfJ KTtGJMh/4xMXz1XCwQm4YQeNJsDXKsqmofkICKlzxDwvtd+nfLQ+YkwPkTYwiyvhLo3jQXrIIeD9I sKQh78gbnuCX5fXPKS4PNfIgn2xk0IZ8VVO3+7UmYNOYebKmmWycqAzqFf6ZCj6fgncHVsXn5e0Ec CqLeYrZokYqEt3CVrqg5KUEPxmztK15oTIqx2JtAGjLb7HB/z29AtPlpYE77rN5jabNgtn0VGxVRb Lab5OkwD97MhRb12HGpOW8QcfjTYBotM5Be5zTq6BklRjCNtzaQUf7TrB58NsLCEqDnYyVfNBu20C tb+XfeEg==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nupap-001XHz-CK; Sat, 28 May 2022 06:06:31 +0000 Date: Fri, 27 May 2022 23:06:31 -0700 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 23/24] hostfs: Handle page write errors correctly Message-ID: References: <20220527155036.524743-1-willy@infradead.org> <20220527155036.524743-24-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220527155036.524743-24-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=zxlEWezo; dmarc=none; spf=none (imf29.hostedemail.com: domain of BATV+c5e11ba0f85895bf2855+6852+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+c5e11ba0f85895bf2855+6852+infradead.org+hch@bombadil.srs.infradead.org X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: D10C2120044 X-Stat-Signature: y8ttmj9fbur3p38774ztyomnrokce5gt X-Rspam-User: X-HE-Tag: 1653717981-815307 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, May 27, 2022 at 04:50:35PM +0100, Matthew Wilcox (Oracle) wrote: > If a page can't be written back, we need to call mapping_set_error(), > not clear the page's Uptodate flag. Also remove the clearing of PageError > on success; that flag is used for read errors, not write errors. Looks good: Reviewed-by: Christoph Hellwig