From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D168C433FE for ; Sat, 28 May 2022 06:04:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DA4708D0006; Sat, 28 May 2022 02:03:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D576C8D0001; Sat, 28 May 2022 02:03:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C42528D0006; Sat, 28 May 2022 02:03:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id B89348D0001 for ; Sat, 28 May 2022 02:03:59 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 9236360E4F for ; Sat, 28 May 2022 06:03:59 +0000 (UTC) X-FDA: 79514110998.24.32EA492 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf05.hostedemail.com (Postfix) with ESMTP id C2648100053 for ; Sat, 28 May 2022 06:03:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=NyQthQJpGcstabnX8JyKAqtCUdWovwhdWvPL8jhV61A=; b=bKlSY2gztszLwfbyS2K4jiT8z6 pFHRc6+3EKjUyuJ4DqXpNXxX4go2lWqRCTJnRWQIZ5Elnwcx1CathJshqdp5W/bOTRHDuRFRLvnyt SmMLwdaD2DVGI8/PWl90GmTrH9d23njJOE4QsxmuS2MHMiuh0RqR+X+rRUacjnn7Na+R9UpTvNosv RdKBBmIPud78ufQCigB++w5fs5ygjvRGcuD6EDle2P79dJlE2nfFwkLtvZurKGroKSw5FSK92V6k7 xhRrSEkAiniiM3VQRH3jRiw1PW6Xih/7SI8ZEtXXvCd3Jj1bqc/sEKb0JoojWGysYGmKy7DEfde9W IFGuiZ7g==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nupYL-001X2z-4M; Sat, 28 May 2022 06:03:57 +0000 Date: Fri, 27 May 2022 23:03:57 -0700 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 20/24] btrfs: Use a folio in wait_dev_supers() Message-ID: References: <20220527155036.524743-1-willy@infradead.org> <20220527155036.524743-21-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220527155036.524743-21-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: C2648100053 X-Stat-Signature: u5phc6e5uqiqwagi6c7cnb8t768r39so Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=bKlSY2gz; dmarc=none; spf=none (imf05.hostedemail.com: domain of BATV+c5e11ba0f85895bf2855+6852+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+c5e11ba0f85895bf2855+6852+infradead.org+hch@bombadil.srs.infradead.org X-HE-Tag: 1653717807-69057 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, May 27, 2022 at 04:50:32PM +0100, Matthew Wilcox (Oracle) wrote: > Remove a use of PageError and optimise putting the page reference twice. Looks good (although the entire code around it could use some love..) Reviewed-by: Christoph Hellwig