From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C7C8C433F5 for ; Sat, 28 May 2022 06:05:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 393C98D0006; Sat, 28 May 2022 02:05:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 31E378D0001; Sat, 28 May 2022 02:05:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 20BAD8D0006; Sat, 28 May 2022 02:05:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 12F2D8D0001 for ; Sat, 28 May 2022 02:05:23 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id D5F88C93 for ; Sat, 28 May 2022 06:05:22 +0000 (UTC) X-FDA: 79514114484.20.5B836B5 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf13.hostedemail.com (Postfix) with ESMTP id 67FDB20052 for ; Sat, 28 May 2022 06:04:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=mBmi5eB1To9ahf6hTQu5xbkhEk5AHfBerDC3nc8GKvk=; b=biOBFMsQpRg/3JY+TpmOD/uvYJ AuLYgUtY4dVllYfmRcw1vzVVdrYKYG+y9IaxH7PWsstt+6p41YQcPQNrNKSqOTno3WnQFwzA1FDN8 ituobb/uQPRNjYTxYnsn+KqokcQE4+TR4uqAN24AGxpOQX+Vywy/sVZhmNApa50R11UBCMVtD0Ee0 5zvXhNnVAyVvrbOZPo6KoIZE7kfSOlzWQ8EE9LAuRxzlIpbtfD2oxWJVJdm1au43wOT3qJqxSG8vr +k59ju8keLPifXYkSZouLIKAaEzTsyMMUFEUQsEV/7vuQuE2EyiCLxgUL9xr3e0lgiXqvTMIiC1fh 1vTcSmWA==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nupZf-001XAz-R6; Sat, 28 May 2022 06:05:19 +0000 Date: Fri, 27 May 2022 23:05:19 -0700 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 21/24] buffer: Don't test folio error in block_read_full_folio() Message-ID: References: <20220527155036.524743-1-willy@infradead.org> <20220527155036.524743-22-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220527155036.524743-22-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 67FDB20052 X-Stat-Signature: qabiau59i4ywtpg7fter1ehtf6gwrr76 Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=biOBFMsQ; dmarc=none; spf=none (imf13.hostedemail.com: domain of BATV+c5e11ba0f85895bf2855+6852+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+c5e11ba0f85895bf2855+6852+infradead.org+hch@bombadil.srs.infradead.org X-Rspam-User: X-HE-Tag: 1653717892-58418 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, May 27, 2022 at 04:50:33PM +0100, Matthew Wilcox (Oracle) wrote: > We can cache this information in a local variable instead of communicating > from one part of the function to another via folio flags. Looks sensibel, but I'd invert the polarity and name this buffers_uptodate to match the API call based on it.