From: Matthew Wilcox <willy@infradead.org>
To: bh1scw@gmail.com
Cc: Christoph Lameter <cl@linux.com>,
Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Andrew Morton <akpm@linux-foundation.org>,
Vlastimil Babka <vbabka@suse.cz>,
Roman Gushchin <roman.gushchin@linux.dev>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Muchun Song <songmuchun@bytedance.com>
Subject: Re: [PATCH] mm/slub: replace alloc_pages with folio_alloc
Date: Sat, 28 May 2022 17:27:11 +0100 [thread overview]
Message-ID: <YpJNX7PN8hAFgVwj@casper.infradead.org> (raw)
In-Reply-To: <20220528161157.3934825-1-bh1scw@gmail.com>
On Sun, May 29, 2022 at 12:11:58AM +0800, bh1scw@gmail.com wrote:
> From: Fanjun Kong <bh1scw@gmail.com>
>
> This patch will use folio allocation functions for allocating pages.
That's not actually a good idea. folio_alloc() will do the
prep_transhuge_page() step which isn't needed for slab.
> Signed-off-by: Fanjun Kong <bh1scw@gmail.com>
> ---
> mm/slub.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/slub.c b/mm/slub.c
> index e5535020e0fd..00c4049a17d6 100644
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -1794,9 +1794,9 @@ static inline struct slab *alloc_slab_page(gfp_t flags, int node,
> unsigned int order = oo_order(oo);
>
> if (node == NUMA_NO_NODE)
> - folio = (struct folio *)alloc_pages(flags, order);
> + folio = (struct folio *)folio_alloc(flags, order);
> else
> - folio = (struct folio *)__alloc_pages_node(node, flags, order);
> + folio = (struct folio *)__folio_alloc_node(node, flags, order);
>
> if (!folio)
> return NULL;
> --
> 2.36.0
>
>
next prev parent reply other threads:[~2022-05-28 16:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-28 16:11 [PATCH] mm/slub: replace alloc_pages with folio_alloc bh1scw
2022-05-28 16:27 ` Matthew Wilcox [this message]
2022-05-29 2:58 ` Muchun Song
2022-05-29 3:31 ` Matthew Wilcox
2022-05-30 0:55 ` Matthew Wilcox
2022-05-30 4:10 ` [mm/slub] 4c863a2fd7: WARNING:at_mm/page_alloc.c:#__alloc_pages kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YpJNX7PN8hAFgVwj@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=bh1scw@gmail.com \
--cc=cl@linux.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=songmuchun@bytedance.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).