From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C06AC433EF for ; Sat, 28 May 2022 16:27:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C610D8D0003; Sat, 28 May 2022 12:27:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C104E8D0001; Sat, 28 May 2022 12:27:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AFE968D0003; Sat, 28 May 2022 12:27:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A336F8D0001 for ; Sat, 28 May 2022 12:27:26 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id 594B9805FC for ; Sat, 28 May 2022 16:27:26 +0000 (UTC) X-FDA: 79515682092.27.9E85ABD Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf04.hostedemail.com (Postfix) with ESMTP id 207F640053 for ; Sat, 28 May 2022 16:27:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=YTEqwGZRFNtxwUVIHGKs3ZV8xkp5O0m4kBntoOiZZ5o=; b=UoeecDCn63hZqFXDKKu7wml7az aDkNJDVHKkIbDz8zPADZEFb1GVkC1iDSW/wo/oVZVfKPaeL5U8zf3LLVvPIV976inQkhlPGwWjWIz Vyi8oJ5PnQrmx03jNiZz9XrRMd7rKu9eTJDoSu1/v4MdHy52iXnNUvkn4M07+kmwWjnhrxUXr3Wab H6crFaO+FEyTxl+NUvcDe2CZwvn/Q2MrILFQF0b1K9h6udPL7zyzJAX9aykBFoBUfLu26YTLwPr/r Kvi43yU6VV/nosb6HooM/lQa2dP8IUh6YE8SHkm7mE4YlaufDp0nraysMwsmQkf+NTGl8VaE8obkv AYTjZpmg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nuzHT-002yuE-Gc; Sat, 28 May 2022 16:27:11 +0000 Date: Sat, 28 May 2022 17:27:11 +0100 From: Matthew Wilcox To: bh1scw@gmail.com Cc: Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Muchun Song Subject: Re: [PATCH] mm/slub: replace alloc_pages with folio_alloc Message-ID: References: <20220528161157.3934825-1-bh1scw@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220528161157.3934825-1-bh1scw@gmail.com> X-Rspamd-Queue-Id: 207F640053 X-Rspam-User: Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=UoeecDCn; spf=none (imf04.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-Stat-Signature: oisip7rjsbyczp3t96ahwaw5qbb56ef5 X-Rspamd-Server: rspam05 X-HE-Tag: 1653755227-398943 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, May 29, 2022 at 12:11:58AM +0800, bh1scw@gmail.com wrote: > From: Fanjun Kong > > This patch will use folio allocation functions for allocating pages. That's not actually a good idea. folio_alloc() will do the prep_transhuge_page() step which isn't needed for slab. > Signed-off-by: Fanjun Kong > --- > mm/slub.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/slub.c b/mm/slub.c > index e5535020e0fd..00c4049a17d6 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -1794,9 +1794,9 @@ static inline struct slab *alloc_slab_page(gfp_t flags, int node, > unsigned int order = oo_order(oo); > > if (node == NUMA_NO_NODE) > - folio = (struct folio *)alloc_pages(flags, order); > + folio = (struct folio *)folio_alloc(flags, order); > else > - folio = (struct folio *)__alloc_pages_node(node, flags, order); > + folio = (struct folio *)__folio_alloc_node(node, flags, order); > > if (!folio) > return NULL; > -- > 2.36.0 > >