From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19C4AC433FE for ; Tue, 31 May 2022 06:59:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A78F36B0075; Tue, 31 May 2022 02:59:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A27C66B0078; Tue, 31 May 2022 02:59:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 93BE46B007B; Tue, 31 May 2022 02:59:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 85BEB6B0075 for ; Tue, 31 May 2022 02:59:03 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id 54F7C120299 for ; Tue, 31 May 2022 06:59:03 +0000 (UTC) X-FDA: 79525136166.14.DA6D9A1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf25.hostedemail.com (Postfix) with ESMTP id 8E0D3A0053 for ; Tue, 31 May 2022 06:58:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=YoT/NLZDDfib5ytOJnRS5vze+GhpYCNRZXiE9Q8MSmo=; b=k8UhONKfGl00SBtcuysxmofSbJ SzfavirDzF9+Mz1TPOVj7NZploaHQcd5FmjgA9TpqF4vQCnLxH3UVjsjBIGBRMjLgLUhd95eXFi0n 1vsqTigsFVMzUnscBxa0z0SA592CHrgmu6yGzNi5IYarBvh3wqEj32/a9lYH9jhZX0/jt7FHKDdBV oqZw7ysM3F0FHDzScJlsGOqsD5mgHd/1mqI6MkBKvXGnytnzGD6uSlrHIjxMAKEQ1gu+fEvrWeXpw 6oXTc5RM/6FLl7/2TLFIx36JRTfwvHzrIfY9waRj6VCMSofFuQRrYMLQlSj8I2xnuPBfnl+k1YwR1 paesYx3w==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nvvqG-009dPt-0X; Tue, 31 May 2022 06:59:00 +0000 Date: Mon, 30 May 2022 23:58:59 -0700 From: Christoph Hellwig To: Stefan Roesch Cc: io-uring@vger.kernel.org, kernel-team@fb.com, linux-mm@kvack.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, david@fromorbit.com, jack@suse.cz, hch@infradead.org Subject: Re: [PATCH v6 05/16] iomap: Add async buffered write support Message-ID: References: <20220526173840.578265-1-shr@fb.com> <20220526173840.578265-6-shr@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220526173840.578265-6-shr@fb.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: 8E0D3A0053 X-Stat-Signature: c6neqm8nqd4yrnd1gcfd9jzgrkhg4oio Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=k8UhONKf; dmarc=none; spf=none (imf25.hostedemail.com: domain of BATV+ed258b20341d80583152+6855+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+ed258b20341d80583152+6855+infradead.org+hch@bombadil.srs.infradead.org X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1653980309-799998 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: I'll leave the throttling algorithm discussion to the experts, but from the pure code POV this looks good to me: Reviewed-by: Christoph Hellwig