From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 736CBC433F5 for ; Wed, 1 Jun 2022 05:26:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E21306B0074; Wed, 1 Jun 2022 01:26:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DCFBC6B0075; Wed, 1 Jun 2022 01:26:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CE02E6B0078; Wed, 1 Jun 2022 01:26:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id BCEAD6B0074 for ; Wed, 1 Jun 2022 01:26:29 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 94DDE34158 for ; Wed, 1 Jun 2022 05:26:29 +0000 (UTC) X-FDA: 79528531698.28.5E86DF0 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf26.hostedemail.com (Postfix) with ESMTP id 4937E140050 for ; Wed, 1 Jun 2022 05:26:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=EhsykQ0DZnIBDvOscgt7MBqRe8U2ul4byyryIhlPIVU=; b=BCbubFmSU1G0Iei7+ZJxqy8HUz tJSpOo8lez9ZAi6FvBvctOHJEqVqM3zFgPClRrzqb0rI93wei0cv/WkK0T1bYXiDyDMiEqNpT4Rm9 aOTcM8+sJKgcml3KN0Y4z+yJrktX04QfH17shVynCzY2tU1dTxWPoxavkmqByFAsnWg2FPYizkHCA J5pCdstia07pshq3jhIOcOR3k53sB4dHJxNYsmWRqs8wTjtH2kib/3T2xuIMJC6B4CvZecSZHE9mA EKv02pCF1EtstiT4RNMcFXB2ZWnqtTJWExwvzqswZb0MrmDU1hS/R3njCHPeVjAhTcVg8efYde93u p5XSSvPw==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwGsB-00DvKN-Ex; Wed, 01 Jun 2022 05:26:23 +0000 Date: Tue, 31 May 2022 22:26:23 -0700 From: Christoph Hellwig To: Stefan Roesch Cc: Christoph Hellwig , io-uring@vger.kernel.org, kernel-team@fb.com, linux-mm@kvack.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, david@fromorbit.com, jack@suse.cz Subject: Re: [PATCH v6 14/16] xfs: Change function signature of xfs_ilock_iocb() Message-ID: References: <20220526173840.578265-1-shr@fb.com> <20220526173840.578265-15-shr@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 4937E140050 Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=BCbubFmS; dmarc=none; spf=none (imf26.hostedemail.com: domain of BATV+0e8eff662a988215b893+6856+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+0e8eff662a988215b893+6856+infradead.org+hch@bombadil.srs.infradead.org X-Stat-Signature: 4381489ung6mi39bd3e7brcnkofefusx X-Rspam-User: X-HE-Tag: 1654061184-828440 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 31, 2022 at 12:15:19PM -0700, Stefan Roesch wrote: > The problem is that xfs_iolock_iocb uses: iocb->ki_filp->f_inode, > but xfs_file_buffered_write: iocb->ki_ki_filp->f_mapping->host > > This requires to pass in the xfs_inode *. Both must be the same. The indirection only matters for device files (and coda).