From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A484C43334 for ; Thu, 2 Jun 2022 12:57:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9D75E6B0071; Thu, 2 Jun 2022 08:57:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 982C36B0072; Thu, 2 Jun 2022 08:57:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 871546B0073; Thu, 2 Jun 2022 08:57:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 7770F6B0071 for ; Thu, 2 Jun 2022 08:57:27 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 4276D20C53 for ; Thu, 2 Jun 2022 12:57:27 +0000 (UTC) X-FDA: 79533296934.01.6401C0E Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf17.hostedemail.com (Postfix) with ESMTP id EEA7140067 for ; Thu, 2 Jun 2022 12:56:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=JFp6WmIipFimbqeAO2j6Pm5GVuKNfBoT3pvUwbllZnA=; b=EaOwh2x2mocIMqrnZBG42H9vhj fFAYFS+ggTcKhu/R2RtmlDR+KMVxQmsqX1pej1AqDXG5+Wc47ebk0leECNPfHABrz4l/c2xKcss+C +2Rd+sZKsuf4Qsm/6GwB8t2NJaK4HdlMPHroCIJYeySix5yjlcgRuGOWKA7N2pRjgz0gJYkL95/NF KpJSmRlKBoNaRgt/tQrpY2Gjf6FMySseSZBQjJl1tu6PFDHBMBrOORRBnnnsbZn/vHqQBSGTxa0gw v1fBZYuwSwLNl+IUoJr3TywjwoLFhA13CKmDcSsTWesLVtg/updwQjCiPm50wQSp5OqH7L/o+S9H5 ocqNU0OQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwkO6-0079V8-OD; Thu, 02 Jun 2022 12:57:18 +0000 Date: Thu, 2 Jun 2022 13:57:18 +0100 From: Matthew Wilcox To: Stefan Roesch Cc: io-uring@vger.kernel.org, kernel-team@fb.com, linux-mm@kvack.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, david@fromorbit.com, jack@suse.cz, hch@infradead.org, axboe@kernel.dk Subject: Re: [PATCH v7 09/15] fs: Split off inode_needs_update_time and __file_update_time Message-ID: References: <20220601210141.3773402-1-shr@fb.com> <20220601210141.3773402-10-shr@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220601210141.3773402-10-shr@fb.com> X-Rspam-User: Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=EaOwh2x2; dmarc=none; spf=none (imf17.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: EEA7140067 X-Stat-Signature: hqooojebsqwtxrqior3nji1fsfca5xnj X-HE-Tag: 1654174609-293001 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 01, 2022 at 02:01:35PM -0700, Stefan Roesch wrote: > + /** > + * file_update_time - update mtime and ctime time > + * @file: file accessed > + * > + * Update the mtime and ctime members of an inode and mark the inode for > + * writeback. Note that this function is meant exclusively for usage in > + * the file write path of filesystems, and filesystems may choose to > + * explicitly ignore updates via this function with the _NOCMTIME inode > + * flag, e.g. for network filesystem where these imestamps are handled > + * by the server. This can return an error for file systems who need to > + * allocate space in order to update an inode. > + * > + * Return: 0 on success, negative errno on failure. > + */ Can you remove the extra leading space from each of these lines?