linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Matthew Wilcox <willy@infradead.org>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: Hsin-Yi Wang <hsinyi@chromium.org>,
	Phillip Lougher <phillip@squashfs.org.uk>,
	Xiongwei Song <Xiongwei.Song@windriver.com>,
	Zheng Liang <zhengliang6@huawei.com>,
	Zhang Yi <yi.zhang@huawei.com>, Hou Tao <houtao1@huawei.com>,
	Miao Xie <miaoxie@huawei.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	"linux-mm @ kvack . org" <linux-mm@kvack.org>,
	"squashfs-devel @ lists . sourceforge . net"
	<squashfs-devel@lists.sourceforge.net>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 3/3] squashfs: implement readahead
Date: Fri, 3 Jun 2022 13:59:09 +0100	[thread overview]
Message-ID: <YpoFnROxAwdSScuV@casper.infradead.org> (raw)
In-Reply-To: <c017d992-2746-045b-47c8-c5b9c3025f1a@samsung.com>

On Fri, Jun 03, 2022 at 02:54:21PM +0200, Marek Szyprowski wrote:
> Hi,
> 
> On 01.06.2022 12:39, Hsin-Yi Wang wrote:
> > Implement readahead callback for squashfs. It will read datablocks
> > which cover pages in readahead request. For a few cases it will
> > not mark page as uptodate, including:
> > - file end is 0.
> > - zero filled blocks.
> > - current batch of pages isn't in the same datablock or not enough in a
> >    datablock.
> > - decompressor error.
> > Otherwise pages will be marked as uptodate. The unhandled pages will be
> > updated by readpage later.
> >
> > Suggested-by: Matthew Wilcox <willy@infradead.org>
> > Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
> > Reported-by: Matthew Wilcox <willy@infradead.org>
> > Reported-by: Phillip Lougher <phillip@squashfs.org.uk>
> > Reported-by: Xiongwei Song <Xiongwei.Song@windriver.com>
> > ---
> 
> This patch landed recently in linux-next as commit 95f7a26191de 
> ("squashfs: implement readahead"). I've noticed that it causes serious 
> issues on my test systems (various ARM 32bit and 64bit based boards). 
> The easiest way to observe is udev timeout 'waiting for /dev to be fully 
> populated' and prolonged booting time. I'm using squashfs for deploying 
> kernel modules via initrd. Reverting aeefca9dfae7 & 95f7a26191deon on 
> top of the next-20220603 fixes the issue.

How large are these files?  Just a few kilobytes?



  reply	other threads:[~2022-06-03 12:59 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-01 10:39 [PATCH v4 0/3] Implement readahead for squashfs Hsin-Yi Wang
2022-06-01 10:39 ` [PATCH v4 1/3] Revert "squashfs: provide backing_dev_info in order to disable read-ahead" Hsin-Yi Wang
2022-06-01 10:39 ` [PATCH v4 2/3] squashfs: always build "file direct" version of page actor Hsin-Yi Wang
2022-06-01 10:39 ` [PATCH v4 3/3] squashfs: implement readahead Hsin-Yi Wang
     [not found]   ` <CGME20220603125421eucas1p17da286a3e7f2d4759aa4c7639dd62f75@eucas1p1.samsung.com>
2022-06-03 12:54     ` Marek Szyprowski
2022-06-03 12:59       ` Matthew Wilcox [this message]
2022-06-03 14:10         ` Marek Szyprowski
2022-06-03 14:55           ` Hsin-Yi Wang
2022-06-03 15:11             ` Marek Szyprowski
2022-06-03 15:29             ` Matthew Wilcox
2022-06-03 15:58               ` Marek Szyprowski
2022-06-06  3:54                 ` Phillip Lougher
2022-06-06  9:55                   ` Hsin-Yi Wang
2022-06-06 11:09                     ` Hsin-Yi Wang
2022-06-06 15:08                       ` Hsin-Yi Wang
2022-06-07  7:35       ` Phillip Lougher
2022-06-13 12:08         ` Marek Szyprowski
2022-06-13 13:45           ` Hsin-Yi Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YpoFnROxAwdSScuV@casper.infradead.org \
    --to=willy@infradead.org \
    --cc=Xiongwei.Song@windriver.com \
    --cc=akpm@linux-foundation.org \
    --cc=houtao1@huawei.com \
    --cc=hsinyi@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=m.szyprowski@samsung.com \
    --cc=miaoxie@huawei.com \
    --cc=phillip@squashfs.org.uk \
    --cc=squashfs-devel@lists.sourceforge.net \
    --cc=yi.zhang@huawei.com \
    --cc=zhengliang6@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).