From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FBE1C43334 for ; Fri, 3 Jun 2022 12:59:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A2BBF8D0003; Fri, 3 Jun 2022 08:59:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9B6718D0001; Fri, 3 Jun 2022 08:59:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 878A88D0003; Fri, 3 Jun 2022 08:59:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 792DA8D0001 for ; Fri, 3 Jun 2022 08:59:28 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 4E43933F80 for ; Fri, 3 Jun 2022 12:59:28 +0000 (UTC) X-FDA: 79536930816.09.C6679BB Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf01.hostedemail.com (Postfix) with ESMTP id A242D4007B for ; Fri, 3 Jun 2022 12:59:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=cLtR22X2YMGBRu4CJqe5w4vOiyDa2dkTADcsreL0J6Y=; b=fro3tgYwYJIMFutExfLTy2/NTc enNFhHBR3bjAlqnjKfkPTxarHHM2BoYPWgwsvy6c5GRj1sKQEw4Dba7t/np1TQF0YM/REBrGPa28X jbBSEuPmGxkO1ruVzQmWkKMvLU0V2TuwhJdXRilN6fAk0zo3ptEDSanCN1R47AsAO4r9ErH6Zktjr 2lZK68C04tg1pXmG+LfJDMR3Hs7dl6Ono6nXbhghfzNVfTsaTjfFk2CpwGwGxcFKrd8uZ6vrHprNa 9NgjQPVxCEoCy02ZQBLuIT3b+7LRWGkIdowBk9lEWqxZqUpW3Z+oHG3d+N+gBWMSRcW6Zd7qv8Ysm YSdyraDw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nx6tR-007uOt-KY; Fri, 03 Jun 2022 12:59:09 +0000 Date: Fri, 3 Jun 2022 13:59:09 +0100 From: Matthew Wilcox To: Marek Szyprowski Cc: Hsin-Yi Wang , Phillip Lougher , Xiongwei Song , Zheng Liang , Zhang Yi , Hou Tao , Miao Xie , Andrew Morton , "linux-mm @ kvack . org" , "squashfs-devel @ lists . sourceforge . net" , linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 3/3] squashfs: implement readahead Message-ID: References: <20220601103922.1338320-1-hsinyi@chromium.org> <20220601103922.1338320-4-hsinyi@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: A242D4007B X-Stat-Signature: 3uytxa6ku3wo5676da3kixtz3qiqpgdh X-Rspam-User: Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=fro3tgYw; spf=none (imf01.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-HE-Tag: 1654261159-10509 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jun 03, 2022 at 02:54:21PM +0200, Marek Szyprowski wrote: > Hi, > > On 01.06.2022 12:39, Hsin-Yi Wang wrote: > > Implement readahead callback for squashfs. It will read datablocks > > which cover pages in readahead request. For a few cases it will > > not mark page as uptodate, including: > > - file end is 0. > > - zero filled blocks. > > - current batch of pages isn't in the same datablock or not enough in a > > datablock. > > - decompressor error. > > Otherwise pages will be marked as uptodate. The unhandled pages will be > > updated by readpage later. > > > > Suggested-by: Matthew Wilcox > > Signed-off-by: Hsin-Yi Wang > > Reported-by: Matthew Wilcox > > Reported-by: Phillip Lougher > > Reported-by: Xiongwei Song > > --- > > This patch landed recently in linux-next as commit 95f7a26191de > ("squashfs: implement readahead"). I've noticed that it causes serious > issues on my test systems (various ARM 32bit and 64bit based boards). > The easiest way to observe is udev timeout 'waiting for /dev to be fully > populated' and prolonged booting time. I'm using squashfs for deploying > kernel modules via initrd. Reverting aeefca9dfae7 & 95f7a26191deon on > top of the next-20220603 fixes the issue. How large are these files? Just a few kilobytes?