From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 623C3CCA47B for ; Wed, 8 Jun 2022 16:02:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C644B8D0005; Wed, 8 Jun 2022 12:02:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C13A38D0001; Wed, 8 Jun 2022 12:02:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B02CB8D0005; Wed, 8 Jun 2022 12:02:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 9D2A98D0001 for ; Wed, 8 Jun 2022 12:02:47 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id 7A680612FC for ; Wed, 8 Jun 2022 16:02:47 +0000 (UTC) X-FDA: 79555536774.05.1CBAD16 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf10.hostedemail.com (Postfix) with ESMTP id 59F74C002E for ; Wed, 8 Jun 2022 16:02:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=JYL5LzwJMvkTknN2K06oEaqVJPOmxsFkjiVJNTycVrw=; b=X+I1FhaXH6WS4+ZGaHmjXumtnF hSMv1wP/ojs80wam+20Lk7FXy18+7BcczL5HefwpYesKkTphZ1xvan83qkGvXvbh1X1hcfU4CYk+3 a8IhuvNpYCyrYbi/279R8dZs9dPVbn7b0rkDGr1JfKpud+bH/f/7KCuDr0VrxNhUfV1UdTGe/Exrp bdjE400FzSvqmUVCnGHFO59IlhUWLZPlD33Eh4sWfaa45ILPYlUY7CwO2mDsrpL1ilaXKfGB/Kt0I tAKJeNKT5w2M4QSVh/EDJ92w5JF6VHLuksFN5sICMhG7SlEO5/KMmexF9zTbYI2fuNTkUefBjh9O4 45XHM6Bw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nyy8m-00CmAT-Km; Wed, 08 Jun 2022 16:02:40 +0000 Date: Wed, 8 Jun 2022 17:02:40 +0100 From: Matthew Wilcox To: Christoph Hellwig Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-mm@kvack.org, linux-nilfs@vger.kernel.org Subject: Re: [PATCH 03/10] ext4: Convert mpage_release_unused_pages() to use filemap_get_folios() Message-ID: References: <20220605193854.2371230-1-willy@infradead.org> <20220605193854.2371230-4-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: yg7hjuuw1sh4ei4wneuehadkp9y4hfeq Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=X+I1FhaX; dmarc=none; spf=none (imf10.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 59F74C002E X-HE-Tag: 1654704166-751863 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 08, 2022 at 01:02:22AM -0700, Christoph Hellwig wrote: > On Sun, Jun 05, 2022 at 08:38:47PM +0100, Matthew Wilcox (Oracle) wrote: > > If the folio is large, it may overlap the beginning or end of the > > unused range. If it does, we need to avoid invalidating it. > > It's never going to be larger for ext4, is it? But either way, > those precautions looks fine. I don't want to say "never". Today, it's not, but if ext4 ever does gain support for large folios, then this is a precaution it will need to take. I'm trying not to leave traps when I do conversions. > Reviewed-by: Christoph Hellwig