From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29FF4C433EF for ; Wed, 8 Jun 2022 18:51:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A7FB26B0071; Wed, 8 Jun 2022 14:51:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A2D386B0072; Wed, 8 Jun 2022 14:51:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 91C2C6B0073; Wed, 8 Jun 2022 14:51:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 827AF6B0071 for ; Wed, 8 Jun 2022 14:51:15 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 4BBC6204BA for ; Wed, 8 Jun 2022 18:51:15 +0000 (UTC) X-FDA: 79555961310.23.5A3F58D Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf11.hostedemail.com (Postfix) with ESMTP id E4BD840031 for ; Wed, 8 Jun 2022 18:51:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Xo6IxmvvWlpGe87V9hy8ELSZqpwDluRkQUN9FYsgsO8=; b=rfHHj2ZHW/C/0Kw1dyw2vOw0dn 036bYpVT7flJX+VCmbfy0jCxWJnwIMEM89kaulpnbntJdGk4aXeMdB+ICG/zDg1bj5dhOO/W1RSZv Lh2EiU6/yeCvhq2bzh73Eh2yv5rTz3Lds46+OofoZM/kVNfUkwtTnX8GWyV6Wal2ofWPNrfewTaBy mlVSQqy/zQwYxiVU6Ul4Ag0dxEAbV9HbMtnmLeT8yWv8Rteq7W4fvMY9CgAdcIvzErW8cBZ71UKz4 CgtlAhW5eU0CSNN2J6EPVvlc9qqRKhifABU2IUPoKXqYE9NsoKeMVQXbARZmCTDhCkenqJzTbm2wy GRT3tY9A==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nz0lo-00Csxy-51; Wed, 08 Jun 2022 18:51:08 +0000 Date: Wed, 8 Jun 2022 19:51:08 +0100 From: Matthew Wilcox To: Stefan Roesch Cc: io-uring@vger.kernel.org, kernel-team@fb.com, linux-mm@kvack.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, david@fromorbit.com, jack@suse.cz, hch@infradead.org, axboe@kernel.dk, Christoph Hellwig , "Darrick J . Wong" Subject: Re: [PATCH v8 04/14] iomap: Add flags parameter to iomap_page_create() Message-ID: References: <20220608171741.3875418-1-shr@fb.com> <20220608171741.3875418-5-shr@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220608171741.3875418-5-shr@fb.com> Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=rfHHj2ZH; dmarc=none; spf=none (imf11.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Stat-Signature: q37dapje7sij4ek8ahgn9xwa6hroe5t8 X-Rspam-User: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: E4BD840031 X-HE-Tag: 1654714274-745876 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 08, 2022 at 10:17:31AM -0700, Stefan Roesch wrote: > +iomap_page_create(struct inode *inode, struct folio *folio, unsigned int flags) > { > struct iomap_page *iop = to_iomap_page(folio); > unsigned int nr_blocks = i_blocks_per_folio(inode, folio); > + gfp_t gfp; > > if (iop || nr_blocks <= 1) > return iop; > > + if (flags & IOMAP_NOWAIT) > + gfp = GFP_NOWAIT; > + else > + gfp = GFP_NOFS | __GFP_NOFAIL; > + > iop = kzalloc(struct_size(iop, uptodate, BITS_TO_LONGS(nr_blocks)), > - GFP_NOFS | __GFP_NOFAIL); > + gfp); > + > spin_lock_init(&iop->uptodate_lock); Umm ... you just changed the gfp flags from NOFAIL to NOWAIT, but you aren't checking to see if iop creation failed?