From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17435C43334 for ; Thu, 9 Jun 2022 03:56:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 951A46B0074; Wed, 8 Jun 2022 23:56:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 901946B0075; Wed, 8 Jun 2022 23:56:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7CA226B007B; Wed, 8 Jun 2022 23:56:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 6D47A6B0074 for ; Wed, 8 Jun 2022 23:56:19 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 54606604F5 for ; Thu, 9 Jun 2022 03:56:19 +0000 (UTC) X-FDA: 79557334878.25.A03F52B Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf02.hostedemail.com (Postfix) with ESMTP id 0B7888003E for ; Thu, 9 Jun 2022 03:56:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=k5NOE2/mOchRWcRvMdsOMX23IRbR4XjJRm5kjerQYfs=; b=UMDExU/q7tF8/mqWoSgLYxhOpC FkB/nDKRBlAlwMswJxYlpwOD+T9b3fHuzs5Xk9HKsw1RzKM18Nvzmz2zvtMnyPCsG0qy2kU/WHu9X mVccNPi9V87DFgmPksbjSq32mvZYh7FU9kikejkUfrcbqMujPYOK4OsnGEYmxwRBuH+8cz929MoC+ J1L5P254VCbTHcr/3B4+pgfRdz1mWvdV10u33rtAMJjWsHP0HN5sU7QukTrtM4bSJeT0tiNaLZ0sf okORJ39zhtNOHmkrX4y3W5zWBlbmRyPPS8qKqjL4e2oY+q3FEDzI+tyRYIGUkaqgz1VdTJg+hKLV8 s6Jccx+g==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nz9HM-00G0pb-DO; Thu, 09 Jun 2022 03:56:16 +0000 Date: Wed, 8 Jun 2022 20:56:16 -0700 From: Christoph Hellwig To: Matthew Wilcox Cc: Christoph Hellwig , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-mm@kvack.org, linux-nilfs@vger.kernel.org Subject: Re: [PATCH 08/10] vmscan: Add check_move_unevictable_folios() Message-ID: References: <20220605193854.2371230-1-willy@infradead.org> <20220605193854.2371230-9-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1654746979; a=rsa-sha256; cv=none; b=NBSdb2HZ6bMofncGvLWI+6WBGIjSpc+8AGzvaIKDsW9JbkRIQBm3Yzw1NuBYKXCI/6zMqJ 9Ds+tuSQe5q5uiHBjtHs2B6LhmTXFv/Zx6isXvn6s9sEqtSdGVGHeGjXCHS20TNprs4SMM 5ZJW8NH7iSs+xC9J2kfFtUedl5LUVdg= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b="UMDExU/q"; spf=none (imf02.hostedemail.com: domain of BATV+a39afe573ddbd6ff3389+6864+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+a39afe573ddbd6ff3389+6864+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1654746979; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=k5NOE2/mOchRWcRvMdsOMX23IRbR4XjJRm5kjerQYfs=; b=osm+qEFhxyWvtJSJbyUWuE0B/Xiz/jlD3fJhCYrg+yCk6hWB1ea12rpSgYzfLHSRsdPept EU7ZqqqtZJVEmJ+2WkWBYXZz7uufm7+p0mngyGbZo74gVBkZ0Ju1AsI6csQlP7LCarlp6R qKbZtpctyiQdlR16PudJwvn4ijrtHlc= X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 0B7888003E X-Rspam-User: Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b="UMDExU/q"; spf=none (imf02.hostedemail.com: domain of BATV+a39afe573ddbd6ff3389+6864+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+a39afe573ddbd6ff3389+6864+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none X-Stat-Signature: cdb4yfcdnmi6ggj993x4spbjkquwgiqt X-HE-Tag: 1654746978-877868 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 08, 2022 at 05:32:34PM +0100, Matthew Wilcox wrote: > On Wed, Jun 08, 2022 at 01:07:32AM -0700, Christoph Hellwig wrote: > > On Sun, Jun 05, 2022 at 08:38:52PM +0100, Matthew Wilcox (Oracle) wrote: > > > Change the guts of check_move_unevictable_pages() over to use folios > > > and add check_move_unevictable_pages() as a wrapper. > > > > The changes here look fine, but please also add patches for converting > > the two callers (which looks mostly trivial to me). > > I do want to get rid of pagevecs entirely, but that conversion isn't > going to happen in time for the next merge window. for_each_sgt_page() > is a little intimidating. for_each_sgt_page, just like other creative scatterlist abuse in the gpu code is a beast. But, instead of doing a for_each_sgt_page to add pages to the pagevec and then do a loop over the pagevec to add to the folio batch it should be pretty trivial to just cut out the middle man.