From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB50DC433EF for ; Tue, 14 Jun 2022 10:20:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1F9618D0238; Tue, 14 Jun 2022 06:20:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 182908D0229; Tue, 14 Jun 2022 06:20:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F3E098D0238; Tue, 14 Jun 2022 06:20:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id E07188D0229 for ; Tue, 14 Jun 2022 06:20:38 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id AE88C352DF for ; Tue, 14 Jun 2022 10:20:38 +0000 (UTC) X-FDA: 79576447356.02.55389A4 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf06.hostedemail.com (Postfix) with ESMTP id 01799180091 for ; Tue, 14 Jun 2022 10:20:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1655202037; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=94Tijhs2krNsUh5sgMXTyng6F8TEy2CILJiweYDy2xE=; b=c1771Fp87tNf+bv5nRdtQsIs3tVBdXsMJBNWZc017Lcc6Ln9UjwJlgTqbuFvQNo+7dz2vV +bRQiKLp+IuY+p6AFnY/6zV4nkO82mhvw+QG9O2u4KSc4yVLSqylo3kYzpwbzZBLofct87 aH9I6IX5Pbe0u/NneJBJPcOjc6X9bUg= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-575-oZmcGoKQNE-UgM_JJWpd_A-1; Tue, 14 Jun 2022 06:20:33 -0400 X-MC-Unique: oZmcGoKQNE-UgM_JJWpd_A-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 50276811E76; Tue, 14 Jun 2022 10:20:31 +0000 (UTC) Received: from localhost (ovpn-12-211.pek2.redhat.com [10.72.12.211]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3A42CC52D63; Tue, 14 Jun 2022 10:20:29 +0000 (UTC) Date: Tue, 14 Jun 2022 18:20:25 +0800 From: Baoquan He To: Wupeng Ma Cc: corbet@lwn.net, will@kernel.org, ardb@kernel.org, catalin.marinas@arm.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, dvhart@infradead.org, andy@infradead.org, rppt@kernel.org, akpm@linux-foundation.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, paulmck@kernel.org, keescook@chromium.org, songmuchun@bytedance.com, rdunlap@infradead.org, damien.lemoal@opensource.wdc.com, swboyd@chromium.org, wei.liu@kernel.org, robin.murphy@arm.com, david@redhat.com, anshuman.khandual@arm.com, thunder.leizhen@huawei.com, wangkefeng.wang@huawei.com, gpiccoli@igalia.com, chenhuacai@kernel.org, geert@linux-m68k.org, vijayb@linux.microsoft.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-efi@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v5 5/5] memblock: Disable mirror feature if kernelcore is not specified Message-ID: References: <20220614092156.1972846-1-mawupeng1@huawei.com> <20220614092156.1972846-6-mawupeng1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220614092156.1972846-6-mawupeng1@huawei.com> X-Scanned-By: MIMEDefang 2.85 on 10.11.54.8 ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655202038; a=rsa-sha256; cv=none; b=RkUBJPKK036a1SaZWbK0cLz7ThWLhGrUAG5aAmF/cNWJPe547i0erD0luNDg2TCNo4470V 8wNn9e4i73lFmLZo6CK65DsNnwK4Gc1m20KgFoUc7AOGdoG0GeojJ5YzBkXoO30bHuMN5J Gish/oJ1aGBF/sidd1pRf4pGKSBIcuY= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=c1771Fp8; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf06.hostedemail.com: domain of bhe@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=bhe@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655202038; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=94Tijhs2krNsUh5sgMXTyng6F8TEy2CILJiweYDy2xE=; b=S4A6HD7F2v/BIPkN5C6yJ5JnVydPNVYacKshrnMM2vpb2pX+r0ah5b+RmEc73edmUnJXX9 pKhBTJj82EQpF/99skxPw9wsup270KDkYaNJXdePpTGH94kikxIZ7Wq+lwmbTHKWTiuivy Op/xQE6OGQUNiWJUNXDpyc25bWAaEBw= X-Rspamd-Queue-Id: 01799180091 X-Rspam-User: Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=c1771Fp8; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf06.hostedemail.com: domain of bhe@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=bhe@redhat.com X-Rspamd-Server: rspam06 X-Stat-Signature: 8zsx1af7qh16sd1amuiqjwrnddzitwds X-HE-Tag: 1655202037-219314 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 06/14/22 at 05:21pm, Wupeng Ma wrote: > From: Ma Wupeng > > If system have some mirrored memory and mirrored feature is not specified > in boot parameter, the basic mirrored feature will be enabled and this will > lead to the following situations: > > - memblock memory allocation prefers mirrored region. This may have some > unexpected influence on numa affinity. > > - contiguous memory will be split into several parts if parts of them > is mirrored memory via memblock_mark_mirror(). > > To fix this, variable mirrored_kernelcore will be checked in > memblock_mark_mirror(). Mark mirrored memory with flag MEMBLOCK_MIRROR iff > kernelcore=mirror is added in the kernel parameters. > > Signed-off-by: Ma Wupeng > Acked-by: Ard Biesheuvel > --- > mm/internal.h | 2 ++ > mm/memblock.c | 3 +++ > mm/page_alloc.c | 2 +- > 3 files changed, 6 insertions(+), 1 deletion(-) > > diff --git a/mm/internal.h b/mm/internal.h > index c0f8fbe0445b..ddd2d6a46f1b 100644 > --- a/mm/internal.h > +++ b/mm/internal.h > @@ -861,4 +861,6 @@ struct folio *try_grab_folio(struct page *page, int refs, unsigned int flags); > > DECLARE_PER_CPU(struct per_cpu_nodestat, boot_nodestats); > > +extern bool mirrored_kernelcore; > + > #endif /* __MM_INTERNAL_H */ > diff --git a/mm/memblock.c b/mm/memblock.c > index b1d2a0009733..a9f18b988b7f 100644 > --- a/mm/memblock.c > +++ b/mm/memblock.c > @@ -924,6 +924,9 @@ int __init_memblock memblock_clear_hotplug(phys_addr_t base, phys_addr_t size) > */ > int __init_memblock memblock_mark_mirror(phys_addr_t base, phys_addr_t size) > { > + if (!mirrored_kernelcore) > + return 0; memblock_mark_mirror() is just a wrapper, maybe we should check this in efi_find_mirror(). Otherwise, how do we explain the message printed out at below in boot log if we don't mark mirror memory at all? void __init efi_find_mirror(void) { ...... if (mirror_size) pr_info("Memory: %lldM/%lldM mirrored memory\n", mirror_size>>20, total_size>>20); } > + > system_has_some_mirror = true; > > return memblock_setclr_flag(base, size, 1, MEMBLOCK_MIRROR); > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index e008a3df0485..10dc35ec7479 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -356,7 +356,7 @@ static unsigned long required_kernelcore_percent __initdata; > static unsigned long required_movablecore __initdata; > static unsigned long required_movablecore_percent __initdata; > static unsigned long zone_movable_pfn[MAX_NUMNODES] __initdata; > -static bool mirrored_kernelcore __meminitdata; > +bool mirrored_kernelcore __initdata_memblock; > > /* movable_zone is the "real" zone pages in ZONE_MOVABLE are taken from */ > int movable_zone; > -- > 2.25.1 > >