From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5AB9C433EF for ; Wed, 15 Jun 2022 03:26:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C28476B0071; Tue, 14 Jun 2022 23:26:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BD7866B0072; Tue, 14 Jun 2022 23:26:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A51316B0073; Tue, 14 Jun 2022 23:26:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 8F9B26B0071 for ; Tue, 14 Jun 2022 23:26:37 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id 5A1C461138 for ; Wed, 15 Jun 2022 03:26:37 +0000 (UTC) X-FDA: 79579032834.24.DC0A173 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) by imf17.hostedemail.com (Postfix) with ESMTP id F3BD540084 for ; Wed, 15 Jun 2022 03:26:36 +0000 (UTC) Received: by mail-pf1-f173.google.com with SMTP id z17so10249041pff.7 for ; Tue, 14 Jun 2022 20:26:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=C93HtqfcN1mAXkHwIBU3fFPJees+CbwmfrsI+Md2MAI=; b=akS8zpw+xuN4sCND+KB8IWuROKWcZyLOI8PDF1qOvq0Ufx2dLMrEiwkw4OiAj9Fme4 tkkBbVWbMu6wBEGc3L1fBj3sYDUpahlBdTkVy21RmZtP9QAmj+FHZPNSPcPbLHcA4ymn c4BXPq3trKlCxx2KJG3GQz39a/JyMsxduaewlpk/Lv/KsmMkwQa8IE5wNceewtft4kfa FrW6Q5JAedojL2y6pEMVot1Zi7nqq8qru+PFk8//yHq/YMtqRq8wphJbCk4sGqM9pyNb irGA8o1tCyj5DghuNQLWjwBFyVyFsiCQ+L/fybzWBb46ODz7sZuY02it8eGkzA9XUraK xmpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=C93HtqfcN1mAXkHwIBU3fFPJees+CbwmfrsI+Md2MAI=; b=yMMRcWJYyPiUOAAUPyrE2smK7e7tkAkLPrvCrOHHxQdUXYvybJv+Py5ut5vpLt/k+y aAaTCMpjK3GzFEb/4uFcxe4BiuQqhu2fNCc9yOphZ+/y40VXjmpqTYE37rGXkNbbacgo ZGX0a/Nu8dbhVbf5DDE/aHfKNtvqGlbz9XyityDVB88wLy8UXEjiN/hOCmhY3e+CAt3Y UxXNGrMwLofuM0r3vLUsjHi8+3imruFG4k27RRmfoH+usIm5h7DexnE3qFx/TP1Kptvl +qKD0240FIHOkD2PL61EtWC4cULaA7iOqIWUhG/nm7lj5vHse8jcdAP5aGailISRBKSO f3yA== X-Gm-Message-State: AJIora9yr1f6ow0WxfVJuEyQK6c9BUBNYDorzzFtuy8sD4Hq1XiUoOQm /zKs5cfOjyiFcbKdrDaPg4U= X-Google-Smtp-Source: AGRyM1sWEp4OqFv5TJJAioNCSt5tAa4gfCGzRTpYyL8Z/lXpyHz8/55Pm/qFQX/bddnuyAC7XBlseQ== X-Received: by 2002:a63:6f0b:0:b0:408:b8d9:f491 with SMTP id k11-20020a636f0b000000b00408b8d9f491mr3187468pgc.496.1655263595932; Tue, 14 Jun 2022 20:26:35 -0700 (PDT) Received: from hyeyoo ([114.29.24.243]) by smtp.gmail.com with ESMTPSA id f4-20020a170902ab8400b00161a40b2135sm7952491plr.104.2022.06.14.20.26.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jun 2022 20:26:35 -0700 (PDT) Date: Wed, 15 Jun 2022 12:26:27 +0900 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: "Edgecombe, Rick P" Cc: "peterz@infradead.org" , "rppt@kernel.org" , "tglx@linutronix.de" , "linux-mm@kvack.org" , "dave.hansen@linux.intel.com" , "Williams, Dan J" , "hpa@zytor.com" , "mingo@redhat.com" , "Christopherson,, Sean" , "Lutomirski, Andy" , "pbonzini@redhat.com" , "Tianyu.Lan@microsoft.com" , "aneesh.kumar@linux.ibm.com" , "chu, jane" , "bp@alien8.de" , "x86@kernel.org" Subject: Re: [RFC 1/2] x86/mm/cpa: always fail when user address is passed Message-ID: References: <20220614063933.13030-1-42.hyeyoo@gmail.com> <20220614063933.13030-2-42.hyeyoo@gmail.com> <5402e3172f71e27e876bf092e8e698ac7e118680.camel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5402e3172f71e27e876bf092e8e698ac7e118680.camel@intel.com> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655263597; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=C93HtqfcN1mAXkHwIBU3fFPJees+CbwmfrsI+Md2MAI=; b=C64RlVaoc3cw7gQBM1Z7YP08fEXDS8qZMdDaqRVF2eSp6Lk+JQMTm3rNazFkYgIjl14Gpq eg+0MNCzpcqh1B8RNCwddLRkkr4Ues56LMHzaW35OZsnu2LMMB5ubCbAdkgN+7vGFLfQW/ FJgehQXtQcfTvmUE8OTM1ltJ8Rz4sD4= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=akS8zpw+; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf17.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.210.173 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655263597; a=rsa-sha256; cv=none; b=QsmHRjXnZ8z/ZkELE4Ab/JgDHWuW9aridFySDoMxYr1K0hCSe3bLkhpyZO3fhMEmd02s9p q2zeqVRystZ6eO0O/vz2AaxocGP78n7kKJH0y45/I0mGKHQ5CI6bEqzf8+X2CfLyI8+MXu ooPEk0VU0xfbFkmGciIF31DQWaAPiGs= X-Rspamd-Queue-Id: F3BD540084 X-Rspam-User: X-Stat-Signature: dh9otod1yj8i8s11hty86z7ctkdawr73 Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=akS8zpw+; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf17.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.210.173 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com X-Rspamd-Server: rspam04 X-HE-Tag: 1655263596-145438 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 14, 2022 at 05:52:31PM +0000, Edgecombe, Rick P wrote: > On Tue, 2022-06-14 at 15:39 +0900, Hyeonggon Yoo wrote: > > Currently CPA is not used for user mappings (only pgd of init_mm > > or and efi_mm is used). For simplicity, always fail when user address > > is passed. > > > > Note that efi_mm uses 1:1 mapping so its address should not be > > considered as user address. > > > > Signed-off-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> > > --- > > arch/x86/mm/pat/set_memory.c | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/arch/x86/mm/pat/set_memory.c > > b/arch/x86/mm/pat/set_memory.c > > index 1abd5438f126..67cf969fed0d 100644 > > --- a/arch/x86/mm/pat/set_memory.c > > +++ b/arch/x86/mm/pat/set_memory.c > > @@ -20,6 +20,7 @@ > > #include > > #include > > #include > > +#include > > > > #include > > #include > > @@ -1514,6 +1515,11 @@ static int __change_page_attr(struct cpa_data > > *cpa, int primary) > > I guess having it here instead of __change_page_attr_set_clr() will > result in the direct map alias addresses getting checked as well. Since > these are determined inside of CPA, I'm not sure if it's needed as > much. It does not check alias address when it failed. I put it in __change_page_attr() with CPA_ARRAY in mind. Because it may not be a single continuous area. > > > pte_t *kpte, old_pte; > > > > address = __cpa_addr(cpa, cpa->curpage); > > + > > + if (WARN((IS_ENABLED(CONFIG_EFI) ? cpa->pgd != efi_mm.pgd : > > true) > > Could it be? > > (!IS_ENABLED(CONFIG_EFI) || cpa->pgd != efi_mm.pgd) Looks better, will update in v2. Thanks! Hyeonggon > > > + && address <= TASK_SIZE_MAX, > > + KERN_WARNING "CPA: Got a user address")) > > + return -EINVAL; > > repeat: > > kpte = _lookup_address_cpa(cpa, address, &level); > > if (!kpte) -- Thanks, Hyeonggon