From: Christoph Hellwig <hch@infradead.org>
To: liubo <liubo254@huawei.com>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, ying.huang@intel.com,
willy@infradead.org, vbabka@suse.cz, surenb@google.com,
peterx@redhat.com, neilb@suse.de, naoya.horiguchi@nec.com,
minchan@kernel.org, linmiaohe@huawei.com,
louhongxiang@huawei.com, linfeilong@huawei.com
Subject: Re: [PATCH v2 2/2] mm/swapfile: release swap info when swap device is unpluged
Date: Wed, 15 Jun 2022 04:22:34 -0700 [thread overview]
Message-ID: <YqnA+nZzkPYsw6CI@infradead.org> (raw)
In-Reply-To: <20220615070228.2858170-3-liubo254@huawei.com>
Sorry, but this is simply broken. We can't just do d_path magic
here. That being said the problem is real, and I think the right
answer is to offer a swapoff variant that doesn't need to open the
underlying device or file, but useѕ some kind of handle. I'm just
not sure what would be a good handle here.
next prev parent reply other threads:[~2022-06-15 11:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-15 7:02 [PATCH v2 0/2] mm/swapfile: release swap info when swap device is unpluged liubo
2022-06-15 7:02 ` [PATCH v2 1/2] mm/swapfile: Extract operations of resource release in the swapoff process liubo
2022-06-15 7:02 ` [PATCH v2 2/2] mm/swapfile: release swap info when swap device is unpluged liubo
2022-06-15 11:22 ` Christoph Hellwig [this message]
2022-06-16 7:00 ` Miaohe Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YqnA+nZzkPYsw6CI@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=linfeilong@huawei.com \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liubo254@huawei.com \
--cc=louhongxiang@huawei.com \
--cc=minchan@kernel.org \
--cc=naoya.horiguchi@nec.com \
--cc=neilb@suse.de \
--cc=peterx@redhat.com \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).