From: Mark Rutland <mark.rutland@arm.com>
To: Tong Tiangen <tongtiangen@huawei.com>
Cc: James Morse <james.morse@arm.com>,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Robin Murphy <robin.murphy@arm.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Michael Ellerman <mpe@ellerman.id.au>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
x86@kernel.org, "H . Peter Anvin" <hpa@zytor.com>,
linuxppc-dev@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Kefeng Wang <wangkefeng.wang@huawei.com>,
Xie XiuQi <xiexiuqi@huawei.com>, Guohanjun <guohanjun@huawei.com>
Subject: Re: [PATCH -next v5 3/8] arm64: extable: move _cond_extable to _cond_uaccess_extable
Date: Fri, 17 Jun 2022 09:31:32 +0100 [thread overview]
Message-ID: <Yqw75OjpUHb1eYBR@FVFF77S0Q05N> (raw)
In-Reply-To: <20220528065056.1034168-4-tongtiangen@huawei.com>
On Sat, May 28, 2022 at 06:50:51AM +0000, Tong Tiangen wrote:
> Currently, We use _cond_extable for cache maintenance uaccess helper
> caches_clean_inval_user_pou(), so this should be moved over to
> EX_TYPE_UACCESS_ERR_ZERO and rename _cond_extable to _cond_uaccess_extable
> for clarity.
>
> Suggested-by: Mark Rutland <mark.rutland@arm.com>
> Signed-off-by: Tong Tiangen <tongtiangen@huawei.com>
Acked-by: Mark Rutland <mark.rutland@arm.com>
Mark.
> ---
> arch/arm64/include/asm/asm-extable.h | 6 +++---
> arch/arm64/include/asm/assembler.h | 4 ++--
> 2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm64/include/asm/asm-extable.h b/arch/arm64/include/asm/asm-extable.h
> index 9c94ac1f082c..d01bd94cc4c2 100644
> --- a/arch/arm64/include/asm/asm-extable.h
> +++ b/arch/arm64/include/asm/asm-extable.h
> @@ -40,9 +40,9 @@
> * Create an exception table entry for `insn` if `fixup` is provided. Otherwise
> * do nothing.
> */
> - .macro _cond_extable, insn, fixup
> - .ifnc \fixup,
> - _asm_extable \insn, \fixup
> + .macro _cond_uaccess_extable, insn, fixup
> + .ifnc \fixup,
> + _asm_extable_uaccess \insn, \fixup
> .endif
> .endm
>
> diff --git a/arch/arm64/include/asm/assembler.h b/arch/arm64/include/asm/assembler.h
> index 8c5a61aeaf8e..dc422fa437c2 100644
> --- a/arch/arm64/include/asm/assembler.h
> +++ b/arch/arm64/include/asm/assembler.h
> @@ -423,7 +423,7 @@ alternative_endif
> b.lo .Ldcache_op\@
> dsb \domain
>
> - _cond_extable .Ldcache_op\@, \fixup
> + _cond_uaccess_extable .Ldcache_op\@, \fixup
> .endm
>
> /*
> @@ -462,7 +462,7 @@ alternative_endif
> dsb ish
> isb
>
> - _cond_extable .Licache_op\@, \fixup
> + _cond_uaccess_extable .Licache_op\@, \fixup
> .endm
>
> /*
> --
> 2.25.1
>
next prev parent reply other threads:[~2022-06-17 8:31 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-28 6:50 [PATCH -next v5 0/8]arm64: add machine check safe support Tong Tiangen
2022-05-28 6:50 ` [PATCH -next v5 1/8] arm64: extable: add new extable type EX_TYPE_KACCESS_ERR_ZERO support Tong Tiangen
2022-06-17 8:23 ` Mark Rutland
2022-06-18 2:44 ` Tong Tiangen
2022-05-28 6:50 ` [PATCH -next v5 2/8] arm64: extable: make uaaccess helper use extable type EX_TYPE_UACCESS_ERR_ZERO Tong Tiangen
2022-06-17 8:24 ` Mark Rutland
2022-06-18 3:26 ` Tong Tiangen
2022-06-18 8:42 ` Tong Tiangen
2022-06-18 12:40 ` Mark Rutland
2022-06-20 2:59 ` Tong Tiangen
2022-06-20 9:10 ` Mark Rutland
2022-06-20 13:32 ` Tong Tiangen
2022-06-20 14:13 ` Tong Tiangen
2022-06-20 14:26 ` Mark Rutland
2022-05-28 6:50 ` [PATCH -next v5 3/8] arm64: extable: move _cond_extable to _cond_uaccess_extable Tong Tiangen
2022-06-17 8:31 ` Mark Rutland [this message]
2022-05-28 6:50 ` [PATCH -next v5 4/8] arm64: extable: cleanup redundant extable type EX_TYPE_FIXUP Tong Tiangen
2022-06-17 8:43 ` Mark Rutland
2022-05-28 6:50 ` [PATCH -next v5 5/8] Add generic fallback version of copy_mc_to_user() Tong Tiangen
2022-05-28 6:50 ` [PATCH -next v5 6/8] arm64: add support for machine check error safe Tong Tiangen
2022-06-17 8:55 ` Mark Rutland
2022-06-18 9:18 ` Tong Tiangen
2022-06-18 12:52 ` Mark Rutland
2022-06-20 1:53 ` Tong Tiangen
2022-05-28 6:50 ` [PATCH -next v5 7/8] arm64: add uaccess to machine check safe Tong Tiangen
2022-06-17 9:06 ` Mark Rutland
2022-06-18 9:27 ` Tong Tiangen
2022-06-18 11:35 ` Mark Rutland
2022-06-20 2:04 ` Tong Tiangen
2022-05-28 6:50 ` [PATCH -next v5 8/8] arm64: add cow " Tong Tiangen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yqw75OjpUHb1eYBR@FVFF77S0Q05N \
--to=mark.rutland@arm.com \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=dave.hansen@linux.intel.com \
--cc=guohanjun@huawei.com \
--cc=hpa@zytor.com \
--cc=james.morse@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=robin.murphy@arm.com \
--cc=tglx@linutronix.de \
--cc=tongtiangen@huawei.com \
--cc=viro@zeniv.linux.org.uk \
--cc=wangkefeng.wang@huawei.com \
--cc=will@kernel.org \
--cc=x86@kernel.org \
--cc=xiexiuqi@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).