From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8D08C43334 for ; Thu, 23 Jun 2022 14:49:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 48C248E0157; Thu, 23 Jun 2022 10:49:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 43C7A8E0144; Thu, 23 Jun 2022 10:49:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 304BF8E0157; Thu, 23 Jun 2022 10:49:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 1D85A8E0144 for ; Thu, 23 Jun 2022 10:49:53 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id BC7D420AE4 for ; Thu, 23 Jun 2022 14:49:52 +0000 (UTC) X-FDA: 79609785024.06.C37AA4C Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) by imf18.hostedemail.com (Postfix) with ESMTP id EC9B31C0024 for ; Thu, 23 Jun 2022 14:49:51 +0000 (UTC) Received: by mail-pg1-f174.google.com with SMTP id g186so19386082pgc.1 for ; Thu, 23 Jun 2022 07:49:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=+qSsChT75v3dvhRAkXYqSV2TfsP5NCarupm2V9Kqui0=; b=Yz5N2ry9uNEF1gaCrCZKOslUu3DOdurMNWT1q6KWoCmT2NDA4a+LtMpMgwsnVfK7zZ RsRoEVr//JBe44DK1MPKhvSYbDQEx/uQDDfuM1g7Fd/GXkj2UvofhpAgxVqE6XuVFjei RcT6g1GMZMEu+84zRGCPZTX491w5ladQzU+KEdRiqOwVWr85a5ka7cpCuMBsW+SyES8p owJ5Gu1oonI/fBRiqhh7dfwfdguVM1ck5qAZBPl7Q3xcxrjQB0vZjt0qFDZWR34kQOjl fcxmI1ChSM01swtv8XSTLbvCTm1tyxxteXF6A4GjAvQYNaZesY9YQzaluqk8xoHdg5+g JdJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=+qSsChT75v3dvhRAkXYqSV2TfsP5NCarupm2V9Kqui0=; b=BpXq2s089/Vgx2Qy0sstT3mBIaEogdNLtHKEyD8NFk8DuBIM9Scchf5WyeZD7erUn8 SD9SB1xLOEtrC2GtwPGfVBwq6DKhEWjlqSUZJiKlPOLf9elVUWi1H6Zv3cPPsHjYnusc 4KzMa5ZIYifDLETaxlcR3D5yHUnz9Nz210A2ROby3GtwcpFe6FF5YmVOmBHkXtgkcvA6 oYAKnMn9XzqJThN4+7osQbRAYCMANhCm2kwqzFBaxBnha0+SUPnZeVacc6bYzpPGxcMY nH+wGqOxYKv5H3VYzvuvmKmlaCShtGRSljOnYo0a8T7GmPGWSEFMClzAVidJvHbQQdEy Ausw== X-Gm-Message-State: AJIora++zw03+j7lkMYqU1yMb5zWmRkuI2So8wbCJ1/dkgP7EPq+zeeR Uxd0ihAiHriwiG4MaIOKodbtFQ== X-Google-Smtp-Source: AGRyM1u61EzUEh+JRGUbY08AnREjTd6Ub3VvJ0Hteh1fCeq4G/TENL2UDjYm4NKsqKEpJH2VZPMPPg== X-Received: by 2002:a05:6a00:9a2:b0:505:974f:9fd6 with SMTP id u34-20020a056a0009a200b00505974f9fd6mr40733440pfg.12.1655995790918; Thu, 23 Jun 2022 07:49:50 -0700 (PDT) Received: from google.com (123.65.230.35.bc.googleusercontent.com. [35.230.65.123]) by smtp.gmail.com with ESMTPSA id i22-20020a17090ad35600b001ec8d191db4sm2003335pjx.17.2022.06.23.07.49.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jun 2022 07:49:50 -0700 (PDT) Date: Thu, 23 Jun 2022 14:49:47 +0000 From: Sean Christopherson To: Peter Xu Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Paolo Bonzini , Andrew Morton , David Hildenbrand , "Dr . David Alan Gilbert" , Andrea Arcangeli , Linux MM Mailing List Subject: Re: [PATCH 2/4] kvm: Merge "atomic" and "write" in __gfn_to_pfn_memslot() Message-ID: References: <20220622213656.81546-1-peterx@redhat.com> <20220622213656.81546-3-peterx@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220622213656.81546-3-peterx@redhat.com> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655995792; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+qSsChT75v3dvhRAkXYqSV2TfsP5NCarupm2V9Kqui0=; b=sAtYzABWf2m1EuD5uQL63WRFOYBugqvhBnreF6kHHU5w037Zz8q4bzkOfOr0AiDjZZchNg uKi8CaXCStINRQbNwxp42UKq7umGDtXgKFb7oi+sjsSrt5VIarUPlxNZW1+D5DaHiQOY5m xLjEiK/wmSuyTBksYnmQOjG3fElyz2g= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=Yz5N2ry9; spf=pass (imf18.hostedemail.com: domain of seanjc@google.com designates 209.85.215.174 as permitted sender) smtp.mailfrom=seanjc@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655995792; a=rsa-sha256; cv=none; b=qwrq96xM9knM/AG1pkWKj+YTm81aYuzxsJYBR57iPZklv/GbsfAKnpD1ILVUzpvyr8rVTT afyUBg2Wc6tSBVIgrWYrxPIn9GYVmg/d5faO81YkEJS4MwGcTPJimmv+Z/Wdo4339b366Y qFtk7+J1OL8oRRducyAtogG/WyS8N7E= X-Rspamd-Queue-Id: EC9B31C0024 Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=Yz5N2ry9; spf=pass (imf18.hostedemail.com: domain of seanjc@google.com designates 209.85.215.174 as permitted sender) smtp.mailfrom=seanjc@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspam-User: X-Stat-Signature: uzapb74nqrak6aicg6mmg5mfrf81kkre X-Rspamd-Server: rspam04 X-HE-Tag: 1655995791-625703 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 22, 2022, Peter Xu wrote: > Merge two boolean parameters into a bitmask flag called kvm_gtp_flag_t for > __gfn_to_pfn_memslot(). This cleans the parameter lists, and also prepare > for new boolean to be added to __gfn_to_pfn_memslot(). ... > @@ -3999,8 +4000,8 @@ static int kvm_faultin_pfn(struct kvm_vcpu *vcpu, struct kvm_page_fault *fault) > } > > async = false; > - fault->pfn = __gfn_to_pfn_memslot(slot, fault->gfn, false, &async, > - fault->write, &fault->map_writable, > + fault->pfn = __gfn_to_pfn_memslot(slot, fault->gfn, flags, > + &async, &fault->map_writable, > &fault->hva); > if (!async) > return RET_PF_CONTINUE; /* *pfn has correct page already */ > @@ -4016,9 +4017,8 @@ static int kvm_faultin_pfn(struct kvm_vcpu *vcpu, struct kvm_page_fault *fault) > } > } > > - fault->pfn = __gfn_to_pfn_memslot(slot, fault->gfn, false, NULL, > - fault->write, &fault->map_writable, > - &fault->hva); > + fault->pfn = __gfn_to_pfn_memslot(slot, fault->gfn, flags, NULL, > + &fault->map_writable, &fault->hva); > return RET_PF_CONTINUE; > } > > diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h > index c20f2d55840c..b646b6fcaec6 100644 > --- a/include/linux/kvm_host.h > +++ b/include/linux/kvm_host.h > @@ -1146,8 +1146,15 @@ kvm_pfn_t gfn_to_pfn_prot(struct kvm *kvm, gfn_t gfn, bool write_fault, > bool *writable); > kvm_pfn_t gfn_to_pfn_memslot(const struct kvm_memory_slot *slot, gfn_t gfn); > kvm_pfn_t gfn_to_pfn_memslot_atomic(const struct kvm_memory_slot *slot, gfn_t gfn); > + > +/* gfn_to_pfn (gtp) flags */ > +typedef unsigned int __bitwise kvm_gtp_flag_t; > + > +#define KVM_GTP_WRITE ((__force kvm_gtp_flag_t) BIT(0)) > +#define KVM_GTP_ATOMIC ((__force kvm_gtp_flag_t) BIT(1)) > + > kvm_pfn_t __gfn_to_pfn_memslot(const struct kvm_memory_slot *slot, gfn_t gfn, > - bool atomic, bool *async, bool write_fault, > + kvm_gtp_flag_t gtp_flags, bool *async, > bool *writable, hva_t *hva); I completely agree the list of booleans is a mess, but I don't love the result of adding @flags. I wonder if we can do something similar to x86's struct kvm_page_fault and add an internal struct to pass params. And then add e.g. gfn_to_pfn_interruptible() to wrap that logic. I suspect we could also clean up the @async behavior at the same time, as its interaction with FOLL_NOWAIT is confusing.