From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90309C43334 for ; Thu, 23 Jun 2022 20:18:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 271058E0189; Thu, 23 Jun 2022 16:18:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 220628E0187; Thu, 23 Jun 2022 16:18:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 110208E0189; Thu, 23 Jun 2022 16:18:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 026D28E0187 for ; Thu, 23 Jun 2022 16:18:46 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id CAFCC608BE for ; Thu, 23 Jun 2022 20:18:45 +0000 (UTC) X-FDA: 79610613810.04.8429418 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf05.hostedemail.com (Postfix) with ESMTP id A07A710002D for ; Thu, 23 Jun 2022 20:18:43 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C8D7FB82519; Thu, 23 Jun 2022 20:18:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 771D7C341C0; Thu, 23 Jun 2022 20:18:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1656015520; bh=4Y6Btbm3nkgs6PBPI5KtoAV5ncZiyw4Kg6nyCDFq27E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=N7++HfGTOukX12sQ0YrOQ90qxaPG7dHXu6m2orKq0Ea2W86NmSBMZsiC2sj+YdE7/ O+pZVGHcqt/6+qyzGloHtSaKOtmqdbKnOJxV46da/IsBcMngUwuwkMtcZT01vvGXKw BYs/m6OujJ1NGvSK5WF8ydz1s9P2j5DSkXGPG8tVmLTq7m0cp+xpncfFR3WB93mz58 Xg5DA6/O7cjZnQE2Va+3GHJ2JjgnjqLAQM8pK+uY8EEHt9QMFf6G2yILbyFmpfCGbQ jPXeinbuf/R/lnWIi8iw0aDuVjFSlYT4wYztEf1bLQDBn3T8K3TT5WG46fmUDie8YY brrFpaVz9JD8Q== Date: Thu, 23 Jun 2022 13:18:39 -0700 From: "Darrick J. Wong" To: Stefan Roesch Cc: io-uring@vger.kernel.org, kernel-team@fb.com, linux-mm@kvack.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, david@fromorbit.com, jack@suse.cz, hch@infradead.org, axboe@kernel.dk, willy@infradead.org Subject: Re: [RESEND PATCH v9 06/14] iomap: Return -EAGAIN from iomap_write_iter() Message-ID: References: <20220623175157.1715274-1-shr@fb.com> <20220623175157.1715274-7-shr@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220623175157.1715274-7-shr@fb.com> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656015523; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xevulIxb/2cpL4i2x+Pl2Qo0QZQ8DxsGF4kyHH29T98=; b=TIteWKfSQXdafwElGmQDp2ITAwMNAMwndeR08HdY7wZBQE/RGMVXeUvjpgpvlXroXgGTRC ACue7ct7dtRPQmBMC3iN4R8gEKAFY+SPkObKhFCoYIyWvnQFCrQLmy7h1f8yRajygkF1af 4jDaDdchqhCdwLsLVaBEaK3YcJLYUGE= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=N7++HfGT; spf=pass (imf05.hostedemail.com: domain of djwong@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=djwong@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656015523; a=rsa-sha256; cv=none; b=rCR/p32/MPfs5/PpEeK7nyuXEfqvELX7C+Cvt9uDHdwN1wMrZmYlqVQU6Vl0XhGC6PAaWK BxQLijYFE1mi/o280ME+BmlZP30SajcP0ybBgJixuEuBRgQbslHvptgiOOeB+VnDXefbVb SWspE8v6SPw094I9vOnJ07Vrvr7H+Tk= Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=N7++HfGT; spf=pass (imf05.hostedemail.com: domain of djwong@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=djwong@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Rspam-User: X-Rspamd-Server: rspam06 X-Stat-Signature: bgocanytbkd6ijp1iqjk1gczso1eafcp X-Rspamd-Queue-Id: A07A710002D X-HE-Tag: 1656015523-677264 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jun 23, 2022 at 10:51:49AM -0700, Stefan Roesch wrote: > If iomap_write_iter() encounters -EAGAIN, return -EAGAIN to the caller. > > Signed-off-by: Stefan Roesch > --- > fs/iomap/buffered-io.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/fs/iomap/buffered-io.c b/fs/iomap/buffered-io.c > index 83cf093fcb92..f2e36240079f 100644 > --- a/fs/iomap/buffered-io.c > +++ b/fs/iomap/buffered-io.c > @@ -830,7 +830,13 @@ static loff_t iomap_write_iter(struct iomap_iter *iter, struct iov_iter *i) > length -= status; > } while (iov_iter_count(i) && length); > > - return written ? written : status; > + if (status == -EAGAIN) { > + iov_iter_revert(i, written); > + return -EAGAIN; > + } > + if (written) > + return written; > + return status; Any particular reason for decomposing the ternary into this? It still looks correct, but it doesn't seem totally necessary... Reviewed-by: Darrick J. Wong --D > } > > ssize_t > -- > 2.30.2 >