From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 123F0C43334 for ; Fri, 24 Jun 2022 05:09:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 61E526B0290; Fri, 24 Jun 2022 01:09:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5A6666B0292; Fri, 24 Jun 2022 01:09:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 447F86B0293; Fri, 24 Jun 2022 01:09:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 2F2D36B0290 for ; Fri, 24 Jun 2022 01:09:42 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id 03AEC60AD5 for ; Fri, 24 Jun 2022 05:09:41 +0000 (UTC) X-FDA: 79611951804.05.257DDDB Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf25.hostedemail.com (Postfix) with ESMTP id A48DDA002A for ; Fri, 24 Jun 2022 05:09:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=tZ8LkmyBAtnykRzYGYg49Rqa9UPNSMXU6tU+2gOJDvM=; b=cCUlw5tMKjA7tpyeYmlc1ERkJa ckf4+aN3hEH0XCskIGjCoiOXbG/eaOHif+X+4wD4wUoGeeukP8mi+q13hfpsaYp4g0soi6gzXhEx1 PpezxbivaQbnsmkilzPYqbCwMv7DF8gmG62CU1v84YZsYJIxP7ph/D9ymTFr2wg7GPJPzhYsTfT2o FtgxLrKn5v8y5kF54+4wuLTtWHxvlH+E/pRlSDlDD9a9kT1sJ5kvyaKgOkvO0HAWSyrXGUVOcgrsN dgSjko4uGfXPAbLp5BBlssWPJVsa+fsSvw8+d2FvD0U2hguXGnTjZkoAPYnfBeCAHIlB4+9lYA/SH DDooLKwA==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1o4bZb-000UJf-9K; Fri, 24 Jun 2022 05:09:39 +0000 Date: Thu, 23 Jun 2022 22:09:39 -0700 From: Christoph Hellwig To: Anshuman Khandual Cc: linux-mm@kvack.org, hch@infradead.org, christophe.leroy@csgroup.eu, Andrew Morton , linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org, x86@kernel.org, openrisc@lists.librecores.org, linux-xtensa@linux-xtensa.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-parisc@vger.kernel.org, linux-alpha@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-um@lists.infradead.org, linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V4 02/26] mm/mmap: Define DECLARE_VM_GET_PAGE_PROT Message-ID: References: <20220624044339.1533882-1-anshuman.khandual@arm.com> <20220624044339.1533882-3-anshuman.khandual@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220624044339.1533882-3-anshuman.khandual@arm.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=cCUlw5tM; spf=none (imf25.hostedemail.com: domain of BATV+825a24a2c69d0abd218e+6879+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+825a24a2c69d0abd218e+6879+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656047381; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tZ8LkmyBAtnykRzYGYg49Rqa9UPNSMXU6tU+2gOJDvM=; b=x5XBHNAhWI242Dk2alZhpP/ociRBO8OWQ3uNh1o1av37BlO2iV+XbSCDjujejRmcPHQjY/ JRWcbqxzYlqrCEgxE8nVPTQ7A3gSR6r0QfNtABiNgqnsfq7ZKAiXLfHcLv45uk8rkfUQdu XPH6zgX7tIqIxu7dOmtGEHEKN/HfLZQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656047381; a=rsa-sha256; cv=none; b=Mi0UpHluq9KAo3PRLLti51dM0rysNcHiXiC72wXf36koMC77NOHsfHbxkrjH7LIPcr0Edk zaajf47lcPCgcm5rYfS552Hy6owPTfASoYxEujUa46BQfsk+B21HX0oDkD1mL2Xr2U/7xD UukM4rhRe64CBeNammE1BD5IQx+9XY4= X-Stat-Signature: 6akgsuj1eh5dqiifwz4t6somug57w7i5 X-Rspamd-Queue-Id: A48DDA002A X-Rspam-User: Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=cCUlw5tM; spf=none (imf25.hostedemail.com: domain of BATV+825a24a2c69d0abd218e+6879+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+825a24a2c69d0abd218e+6879+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none X-Rspamd-Server: rspam02 X-HE-Tag: 1656047381-842416 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jun 24, 2022 at 10:13:15AM +0530, Anshuman Khandual wrote: > This just converts the generic vm_get_page_prot() implementation into a new > macro i.e DECLARE_VM_GET_PAGE_PROT which later can be used across platforms > when enabling them with ARCH_HAS_VM_GET_PAGE_PROT. This does not create any > functional change. mm.h is a huhe header included by almost everything in the kernel. I'd rather have it in something only included in a few files. If we can't find anything suitable it might be worth to add a header just for this even.