From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FFC4C433EF for ; Tue, 28 Jun 2022 13:28:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 99FB58E0001; Tue, 28 Jun 2022 09:28:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 929486B0072; Tue, 28 Jun 2022 09:28:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7A11D8E0001; Tue, 28 Jun 2022 09:28:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 653346B0071 for ; Tue, 28 Jun 2022 09:28:20 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 2AD8921246 for ; Tue, 28 Jun 2022 13:28:20 +0000 (UTC) X-FDA: 79627723560.30.E03AAED Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf14.hostedemail.com (Postfix) with ESMTP id 90456100037 for ; Tue, 28 Jun 2022 13:28:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1656422898; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PH7wMQRYi1ZWFVxyL/3d+sZ7rcf181kH7ObPj88vxe0=; b=TCjYsq9XEdoy0jbmQXqcg2qcWB13azoELplc8JkC1XvnSHTnfhJRBpfavpM1tYh48xmR/Q CIPK/tgpSd3BU0vCJ+UOHUfGOdyMLYlLNBsDcIHCpqHxYpThXR4LxX+m4dw+ozZW0gtP0j WK4lYd4EgaQLkEg3Le00JgezpVx8Goc= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-221-Q4kL-BdJO0eyzAm1fNc-8A-1; Tue, 28 Jun 2022 09:28:17 -0400 X-MC-Unique: Q4kL-BdJO0eyzAm1fNc-8A-1 Received: by mail-wm1-f72.google.com with SMTP id k5-20020a05600c0b4500b003941ca130f9so5117657wmr.0 for ; Tue, 28 Jun 2022 06:28:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=PH7wMQRYi1ZWFVxyL/3d+sZ7rcf181kH7ObPj88vxe0=; b=vviLU9Nyd4cOsSfD0PEBi3bKjSzWT1uIC6Mlm8vNcFmRLjz7YmgVo5hgx/SaphnJp+ NPcV9a9lJTx3JWCHCr5ZbYD/iGO1GPvjcHhfTNLMHZOCSrfPXSPX+P+r0x2nT44E4mNa q7E6vSqnlW6zLsSrHcsfi9wggImq2hb82eUb78K4W1HZwvS0X1VdU4RQed9yrGTaHeqd /1yGS1qCdGTxpjtHYA1U9RnCwlZeIiDGVxa7Yd6PvWVoz33/Nki5LMBoqp/DsxxZ7LlG mT3Wry9FtB6whMn2YEdL0ia5IuTowJ1CAkJHfJbMyZHMfuQj0SNDQZ8hrcZNV0ruTpmk SFag== X-Gm-Message-State: AJIora/bxmFz1A55sqlQSMWpeX0FFNuWatyMtQflOehh/YH7qDsgTqbk UK1y6sLK/wqEIhEgfWk05nXRvSBgzsn1n7XStYy3g/PtEkD29t3hKgqSA8F4C2h6qtRPx37Hov2 TMBiFugoRmRI= X-Received: by 2002:a5d:5047:0:b0:21b:92b2:f34f with SMTP id h7-20020a5d5047000000b0021b92b2f34fmr17127844wrt.677.1656422896392; Tue, 28 Jun 2022 06:28:16 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tqVf5A7KSxbTw31AFhCSUb6QIduyx0h8n4yb62+NQ1QBxlS5VZpJjh7TfSMSbhzJ+0xSz+Vw== X-Received: by 2002:a5d:5047:0:b0:21b:92b2:f34f with SMTP id h7-20020a5d5047000000b0021b92b2f34fmr17127781wrt.677.1656422895955; Tue, 28 Jun 2022 06:28:15 -0700 (PDT) Received: from work-vm (cpc109025-salf6-2-0-cust480.10-2.cable.virginm.net. [82.30.61.225]) by smtp.gmail.com with ESMTPSA id w9-20020a5d6089000000b0020e5b4ebaecsm13771290wrt.4.2022.06.28.06.28.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jun 2022 06:28:15 -0700 (PDT) Date: Tue, 28 Jun 2022 14:28:12 +0100 From: "Dr. David Alan Gilbert" To: Ashish Kalra Cc: x86@kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com, ardb@kernel.org, pbonzini@redhat.com, seanjc@google.com, vkuznets@redhat.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, dovmurik@linux.ibm.com, tobin@ibm.com, bp@alien8.de, michael.roth@amd.com, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, marcorr@google.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, jarkko@kernel.org Subject: Re: [PATCH Part2 v6 36/49] KVM: SVM: Add support to handle GHCB GPA register VMGEXIT Message-ID: References: MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/2.2.6 (2022-06-05) X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656422899; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PH7wMQRYi1ZWFVxyL/3d+sZ7rcf181kH7ObPj88vxe0=; b=Q5XBFQ2QKpLUe7CFPsTYVINVd7MH4GGknJylKYATUzE+O/m0V9It4u2WPZpv8an6WKJwqD 7yVsnmav22UmVjXFRMQimj95aNwVYlPkoKgo4HW9tgC7KFcnoW1qL4U50EQox5kPyNbX3X Srkw9RgSjABgX9Dkizm4mBRXjE6EC7E= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=TCjYsq9X; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf14.hostedemail.com: domain of dgilbert@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=dgilbert@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656422899; a=rsa-sha256; cv=none; b=PUqXUav4MT5pqQvVG4568S1OrKEnSKz3veMZK6czyzwTGKECMShtR3SRcNnaNo1hu80iEs t0LUDyPm8YIstA5W9zyfPAYUV5kJxl6id5CqzDLjYk4E7++citfhM4y5mH48iUyPjAdVvr 50T00efaXHJ2slq7zSDGoxz/vpv2KY0= X-Rspamd-Queue-Id: 90456100037 Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=TCjYsq9X; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf14.hostedemail.com: domain of dgilbert@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=dgilbert@redhat.com X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 8wf1dpt4pcrab7ka5kyxdth1ptuheei9 X-HE-Tag: 1656422899-797524 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: * Ashish Kalra (Ashish.Kalra@amd.com) wrote: > From: Brijesh Singh > > SEV-SNP guests are required to perform a GHCB GPA registration. Before > using a GHCB GPA for a vCPU the first time, a guest must register the > vCPU GHCB GPA. If hypervisor can work with the guest requested GPA then > it must respond back with the same GPA otherwise return -1. > > On VMEXIT, Verify that GHCB GPA matches with the registered value. If a > mismatch is detected then abort the guest. > > Signed-off-by: Brijesh Singh > --- > arch/x86/include/asm/sev-common.h | 8 ++++++++ > arch/x86/kvm/svm/sev.c | 27 +++++++++++++++++++++++++++ > arch/x86/kvm/svm/svm.h | 7 +++++++ > 3 files changed, 42 insertions(+) > > diff --git a/arch/x86/include/asm/sev-common.h b/arch/x86/include/asm/sev-common.h > index 539de6b93420..0a9055cdfae2 100644 > --- a/arch/x86/include/asm/sev-common.h > +++ b/arch/x86/include/asm/sev-common.h > @@ -59,6 +59,14 @@ > #define GHCB_MSR_AP_RESET_HOLD_RESULT_POS 12 > #define GHCB_MSR_AP_RESET_HOLD_RESULT_MASK GENMASK_ULL(51, 0) > > +/* Preferred GHCB GPA Request */ > +#define GHCB_MSR_PREF_GPA_REQ 0x010 > +#define GHCB_MSR_GPA_VALUE_POS 12 > +#define GHCB_MSR_GPA_VALUE_MASK GENMASK_ULL(51, 0) Are the magic 51's in here fixed ? Dave > +#define GHCB_MSR_PREF_GPA_RESP 0x011 > +#define GHCB_MSR_PREF_GPA_NONE 0xfffffffffffff > + > /* GHCB GPA Register */ > #define GHCB_MSR_REG_GPA_REQ 0x012 > #define GHCB_MSR_REG_GPA_REQ_VAL(v) \ > diff --git a/arch/x86/kvm/svm/sev.c b/arch/x86/kvm/svm/sev.c > index c70f3f7e06a8..6de48130e414 100644 > --- a/arch/x86/kvm/svm/sev.c > +++ b/arch/x86/kvm/svm/sev.c > @@ -3331,6 +3331,27 @@ static int sev_handle_vmgexit_msr_protocol(struct vcpu_svm *svm) > GHCB_MSR_INFO_MASK, GHCB_MSR_INFO_POS); > break; > } > + case GHCB_MSR_PREF_GPA_REQ: { > + set_ghcb_msr_bits(svm, GHCB_MSR_PREF_GPA_NONE, GHCB_MSR_GPA_VALUE_MASK, > + GHCB_MSR_GPA_VALUE_POS); > + set_ghcb_msr_bits(svm, GHCB_MSR_PREF_GPA_RESP, GHCB_MSR_INFO_MASK, > + GHCB_MSR_INFO_POS); > + break; > + } > + case GHCB_MSR_REG_GPA_REQ: { > + u64 gfn; > + > + gfn = get_ghcb_msr_bits(svm, GHCB_MSR_GPA_VALUE_MASK, > + GHCB_MSR_GPA_VALUE_POS); > + > + svm->sev_es.ghcb_registered_gpa = gfn_to_gpa(gfn); > + > + set_ghcb_msr_bits(svm, gfn, GHCB_MSR_GPA_VALUE_MASK, > + GHCB_MSR_GPA_VALUE_POS); > + set_ghcb_msr_bits(svm, GHCB_MSR_REG_GPA_RESP, GHCB_MSR_INFO_MASK, > + GHCB_MSR_INFO_POS); > + break; > + } > case GHCB_MSR_TERM_REQ: { > u64 reason_set, reason_code; > > @@ -3381,6 +3402,12 @@ int sev_handle_vmgexit(struct kvm_vcpu *vcpu) > return 1; > } > > + /* SEV-SNP guest requires that the GHCB GPA must be registered */ > + if (sev_snp_guest(svm->vcpu.kvm) && !ghcb_gpa_is_registered(svm, ghcb_gpa)) { > + vcpu_unimpl(&svm->vcpu, "vmgexit: GHCB GPA [%#llx] is not registered.\n", ghcb_gpa); > + return -EINVAL; > + } > + > ret = sev_es_validate_vmgexit(svm, &exit_code); > if (ret) > return ret; > diff --git a/arch/x86/kvm/svm/svm.h b/arch/x86/kvm/svm/svm.h > index c80352c9c0d6..54ff56cb6125 100644 > --- a/arch/x86/kvm/svm/svm.h > +++ b/arch/x86/kvm/svm/svm.h > @@ -206,6 +206,8 @@ struct vcpu_sev_es_state { > */ > u64 ghcb_sw_exit_info_1; > u64 ghcb_sw_exit_info_2; > + > + u64 ghcb_registered_gpa; > }; > > struct vcpu_svm { > @@ -334,6 +336,11 @@ static inline bool sev_snp_guest(struct kvm *kvm) > return sev_es_guest(kvm) && sev->snp_active; > } > > +static inline bool ghcb_gpa_is_registered(struct vcpu_svm *svm, u64 val) > +{ > + return svm->sev_es.ghcb_registered_gpa == val; > +} > + > static inline void vmcb_mark_all_dirty(struct vmcb *vmcb) > { > vmcb->control.clean = 0; > -- > 2.25.1 > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK