From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCFF2C43334 for ; Wed, 29 Jun 2022 17:14:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4EAFC8E0019; Wed, 29 Jun 2022 13:14:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 474518E0015; Wed, 29 Jun 2022 13:14:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 314BA8E0019; Wed, 29 Jun 2022 13:14:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 1C14F8E0015 for ; Wed, 29 Jun 2022 13:14:55 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id E658E1E3 for ; Wed, 29 Jun 2022 17:14:54 +0000 (UTC) X-FDA: 79631923308.11.272AAB6 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf05.hostedemail.com (Postfix) with ESMTP id E0C2910002F for ; Wed, 29 Jun 2022 17:14:53 +0000 (UTC) Received: from pps.filterd (m0098409.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 25TGv3Ea032114; Wed, 29 Jun 2022 17:14:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=pp1; bh=9WOghiGYjmTOE9cfm27FAgUV1NRqxvLgAiknvneQ3DQ=; b=aeOP5NpD4lWxt2YjPH1qcfdYIb0q6B7oQ9UD3SSdBm5XmRqtWMAmNySf0gtU9a34IMBX Q0yKdi6yPFNhM7ZCT0woLd/NpTlgHAmvNW1kpzMcAUH+JKvhnhtXxPYS8QkC5xJirzRa yhvIZcze1x66YPkjLsbX0x+9Yl6CAtXm3vV7wSIyHA52BnhysWm5TAFZsVT5yr7abYF2 N7hLMqAG3t4kueAg9vGwcuLFu0U97r9FRaQVUCCe3d5day/G+KljVQVTeB1A4VOxV6R6 hokYZKaLMJUlM+tKET/UkGVgAyIhfsXT6dW5bpwjkVkmh98qbGwpUrwszsdeA2MstEDg iw== Received: from ppma04fra.de.ibm.com (6a.4a.5195.ip4.static.sl-reverse.com [149.81.74.106]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3h0tnj0pr8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 29 Jun 2022 17:14:51 +0000 Received: from pps.filterd (ppma04fra.de.ibm.com [127.0.0.1]) by ppma04fra.de.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 25TH6FZg019425; Wed, 29 Jun 2022 17:14:49 GMT Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by ppma04fra.de.ibm.com with ESMTP id 3gwt095468-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 29 Jun 2022 17:14:49 +0000 Received: from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com [9.149.105.61]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 25THEkap21561740 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 29 Jun 2022 17:14:46 GMT Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 53D2F11C050; Wed, 29 Jun 2022 17:14:46 +0000 (GMT) Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E360311C04A; Wed, 29 Jun 2022 17:14:45 +0000 (GMT) Received: from osiris (unknown [9.145.11.87]) by d06av25.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Wed, 29 Jun 2022 17:14:45 +0000 (GMT) Date: Wed, 29 Jun 2022 19:14:44 +0200 From: Heiko Carstens To: Steffen Eiden Cc: Alexander Gordeev , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , Vasily Gorbik , linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, nrb@linux.ibm.com Subject: Re: [RFC PATCH] s390: Autoload uvdevice module based on CPU feature Message-ID: References: <20220629153741.195789-1-seiden@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220629153741.195789-1-seiden@linux.ibm.com> X-TM-AS-GCONF: 00 X-Proofpoint-GUID: pe7o9eHQz2WHNlAQFgs_pTXeNLxAndKE X-Proofpoint-ORIG-GUID: pe7o9eHQz2WHNlAQFgs_pTXeNLxAndKE X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-06-29_18,2022-06-28_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 spamscore=0 priorityscore=1501 malwarescore=0 adultscore=0 clxscore=1011 mlxscore=0 suspectscore=0 lowpriorityscore=0 mlxlogscore=564 bulkscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2204290000 definitions=main-2206290062 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656522894; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9WOghiGYjmTOE9cfm27FAgUV1NRqxvLgAiknvneQ3DQ=; b=wiM8F26+bcvfhofNExH8czSG6lH+JmgHqBRdYpajWTqdd/U7+nsYojpiHf4Z7hYsyBwb/d ozWp4NGa2UMf1Q0hhWsdyMp3TuyYmoW+grfsSak0LFnf3k1gLmEXYfSCjlRkqOc8mZR1kZ h/x41Ed3kCwEvTjKSa6GSJuS14IU2BU= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=aeOP5NpD; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf05.hostedemail.com: domain of hca@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=hca@linux.ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656522894; a=rsa-sha256; cv=none; b=FmHr+8mMgf41+iMYr0JXZdsC9zFfNj7x8F0BcNsMJzaKsh3KRRDf8id2LLJGanhyY/Fqnv 9yk9ZSMW+IumxVBR9POphjo+IEFLlxO7XR1Hzw9p/PAHlShXIDMYht5WOn8NoJm4Tu0fzI UX3jLMJnucr0H2txHow8M9ITto6cbSk= X-Rspamd-Queue-Id: E0C2910002F Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=aeOP5NpD; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf05.hostedemail.com: domain of hca@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=hca@linux.ibm.com X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 88qx7rbbi9objtntdu76mumbcbuqdjps X-HE-Tag: 1656522893-229912 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 29, 2022 at 05:37:41PM +0200, Steffen Eiden wrote: > With this patch the uvdevice will be automatically loaded when the > facility 158 is present. This is accomplished by using > ``module_cpu_feature_match`` and adding HWCAP_UV > connected to to facility 158. > > Signed-off-by: Steffen Eiden > --- > arch/s390/include/asm/elf.h | 2 ++ > arch/s390/kernel/processor.c | 5 +++++ > drivers/s390/char/uvdevice.c | 5 ++--- > 3 files changed, 9 insertions(+), 3 deletions(-) Please split this into two patches: one which adds the hwcap bit, and one which makes use of it. Also please make sure the subject contains (nearly) always a component, which would be "s390/hwcaps: ..." in this case. > + /* IBM Secure Execution (Ultravisor) support */ > + if (test_facility(158)) { > + elf_hwcap |= HWCAP_UV; Just keep the comment short like all other one and take the PoP as reference. I would have expected something like: "ultravisor-call (secure execution)" Besides that, everything looks ok as far as I can tell.